Part two of fallback crash handler for Crashpad handler process.

components/crash/content/app/fallback_crash_handler_win_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/crash/content/app/fallback_crash_handler_win.h"
+
+#include "base/command_line.h"
+#include "base/files/file_path.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/threading/platform_thread.h"
+#include "base/win/scoped_handle.h"
+#include "base/win/win_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/crashpad/crashpad/client/crash_report_database.h"
+#include "third_party/crashpad/crashpad/client/settings.h"
+#include "third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump.h"
+#include "third_party/crashpad/crashpad/util/file/file_reader.h"
+#include "third_party/crashpad/crashpad/util/misc/uuid.h"
+
+namespace crash_reporter {
+
+namespace {
+
+class FallbackCrashHandlerWinTest : public testing::Test {
+ public:
+  FallbackCrashHandlerWinTest() {
+    RtlCaptureContext(&ctx_);
+    memset(&exc_, 0, sizeof(exc_));
+    exc_.ExceptionCode = EXCEPTION_ACCESS_VIOLATION;
+
+    exc_ptrs_.ExceptionRecord = &exc_;
+    exc_ptrs_.ContextRecord = &ctx_;
+  }
+
+  void SetUp() override {
+    ASSERT_TRUE(database_dir_.CreateUniqueTempDir());
+
+    // Open a handle to our own process.
+    DWORD kAccessMask =

[scottmg, 2017/01/10 18:26:28]

const

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Done.

+        PROCESS_QUERY_INFORMATION | PROCESS_VM_READ | PROCESS_DUP_HANDLE;
+    self_.Set(OpenProcess(kAccessMask, FALSE, GetCurrentProcessId()));
+    ASSERT_EQ(ERROR_SUCCESS, GetLastError());

[scottmg, 2017/01/10 18:26:28]

Does OpenProcess() necessarily set GLE on success? I think only checking
self.IsValid() by itself is better (and add a log of GLE if you want to have the
test output that on failure).

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Good point - so amended.

+    EXPECT_TRUE(self_.IsValid());
+  }
+
+  std::string ExcPtrsAsString() const {
+    return base::UintToString(reinterpret_cast<uintptr_t>(&exc_ptrs_));
+  };
+
+  std::string ProcessAsString() const {
+    return base::UintToString(base::win::HandleToUint32(self_.Get()));
+  };
+
+  void CreateDatabase() {
+    std::unique_ptr<crashpad::CrashReportDatabase> database =
+        crashpad::CrashReportDatabase::InitializeWithoutCreating(
+            database_dir_.GetPath());
+  }
+
+ protected:
+  CONTEXT ctx_;

[scottmg, 2017/01/10 18:26:28]

context_ and exception_ instead of ctx_ and exc_ please.

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Done.

+  EXCEPTION_RECORD exc_;
+  EXCEPTION_POINTERS exc_ptrs_;
+
+  base::win::ScopedHandle self_;

[scottmg, 2017/01/10 18:26:28]

Since you have to leak this in all usages, perhaps a raw HANDLE is a better
option here.

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Done.

+  base::ScopedTempDir database_dir_;

[scottmg, 2017/01/10 18:26:28]

DISALLOW_COPY_AND_ASSIGN

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Done.

+};
+
+}  // namespace
+
+TEST_F(FallbackCrashHandlerWinTest, ParseCommandLine) {
+  FallbackCrashHandler handler;
+
+  // An empty command line shouldn't work.
+  base::CommandLine cmd_line(base::FilePath(L"empty"));
+  EXPECT_FALSE(handler.ParseCommandLine(cmd_line));
+
+  cmd_line.AppendSwitchPath("database", database_dir_.GetPath());
+  cmd_line.AppendSwitchASCII("exception-pointers", ExcPtrsAsString());
+  cmd_line.AppendSwitchASCII("process", ProcessAsString());
+
+  // Thread missing, still should fail.
+  EXPECT_FALSE(handler.ParseCommandLine(cmd_line));

[scottmg, 2017/01/10 18:26:28]

I guess this should be ASSERT as otherwise it's tried to take the handle from
process arg.

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Done, though this process is pretty horked either way. At least there'll be a
clean failure here.

+
+  cmd_line.AppendSwitchASCII(
+      "thread", base::UintToString(base::PlatformThread::CurrentId()));
+
+  // Should succeed with a fully populated command line.
+  // Because how handle ownership is guarded, we have to "disown" it before

[scottmg, 2017/01/10 18:26:28]

"Because of how..."

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Done.

+  // the handler takes it over.
+  self_.Take();
+  EXPECT_TRUE(handler.ParseCommandLine(cmd_line));
+}
+
+TEST_F(FallbackCrashHandlerWinTest, GenerateCrashDump) {
+  FallbackCrashHandler handler;
+
+  base::CommandLine cmd_line(base::FilePath(L"empty"));
+  cmd_line.AppendSwitchPath("database", database_dir_.GetPath());
+  cmd_line.AppendSwitchASCII("exception-pointers", ExcPtrsAsString());
+
+  // TODO(siggi): It's probably safer to spawn a sacrificial process and then
+  //     terminate it. MinidumpWriteDump is alleged to occasionally hang if used

[scottmg, 2017/01/10 18:26:28]

MiniDump

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Done.

+  //     to dump own process.
+  cmd_line.AppendSwitchASCII("process", ProcessAsString());
+  cmd_line.AppendSwitchASCII(
+      "thread", base::UintToString(base::PlatformThread::CurrentId()));
+
+  // Because how handle ownership is guarded, we have to "disown" this before
+  // the handler takes it over.
+  self_.Take();
+
+  ASSERT_TRUE(handler.ParseCommandLine(cmd_line));
+
+  const char kProduct[] = "SomeProduct";
+  const char kVersion[] = "1.2.3.6";
+  const char kChannel[] = "canary";
+  const char kProcessType[] = "Test";
+
+  EXPECT_TRUE(
+      handler.GenerateCrashDump(kProduct, kVersion, kChannel, kProcessType));
+
+  // Validate that the database contains one valid crash dump.
+  std::unique_ptr<crashpad::CrashReportDatabase> database =
+      crashpad::CrashReportDatabase::InitializeWithoutCreating(
+          database_dir_.GetPath());
+
+  std::vector<crashpad::CrashReportDatabase::Report> reports;
+  ASSERT_EQ(crashpad::CrashReportDatabase::kNoError,
+            database->GetPendingReports(&reports));
+
+  EXPECT_EQ(1U, reports.size());
+
+  // Validate crashpad can read the produced minidump.
+  crashpad::FileReader minidump_file_reader;
+  ASSERT_TRUE(minidump_file_reader.Open(reports[0].file_path));
+
+  crashpad::ProcessSnapshotMinidump minidump_process_snapshot;
+  ASSERT_TRUE(minidump_process_snapshot.Initialize(&minidump_file_reader));
+
+  crashpad::UUID expected_client_id;
+  ASSERT_TRUE(database->GetSettings()->GetClientID(&expected_client_id));
+
+  // Validate that the CrashpadInfo in the report contains the same basic
+  // info, as does the database.
+  crashpad::UUID client_id;
+  minidump_process_snapshot.ClientID(&client_id);
+  ASSERT_EQ(expected_client_id, client_id);

[scottmg, 2017/01/10 18:26:28]

All the ASSERT_ from here down should be EXPECT_ I think.

[Sigurður Ásgeirsson, 2017/01/10 21:21:41]

Done.

+
+  crashpad::UUID report_id;
+  minidump_process_snapshot.ReportID(&report_id);
+  ASSERT_EQ(reports[0].uuid, report_id);
+
+  std::map<std::string, std::string> parameters =
+      minidump_process_snapshot.AnnotationsSimpleMap();
+  auto it = parameters.find("prod");
+  ASSERT_NE(parameters.end(), it);
+  ASSERT_EQ(kProduct, it->second);
+
+  it = parameters.find("ver");
+  ASSERT_NE(parameters.end(), it);
+  ASSERT_EQ(kVersion, it->second);
+
+  it = parameters.find("channel");
+  ASSERT_NE(parameters.end(), it);
+  ASSERT_EQ(kChannel, it->second);
+
+  it = parameters.find("plat");
+  ASSERT_NE(parameters.end(), it);
+#if defined(ARCH_CPU_64_BITS)
+  ASSERT_EQ("Win64", it->second);
+#else
+  ASSERT_EQ("Win32", it->second);
+#endif
+
+  it = parameters.find("ptype");
+  ASSERT_NE(parameters.end(), it);
+  ASSERT_EQ(kProcessType, it->second);
+}
+
+}  // namespace crash_reporter