Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2611343002: Cleanup embedder API functions for app snapshots. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup embedder API functions for app snapshots. - Rename functions to make correspondence between JIT and AOT app snapshot clearer. - Update documentation on assembly output of AOT snapshots. - Remove old Dart_PrecompileJIT. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f51d1b229c5f621e5a5132243ba5604f2a5340de

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -101 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/main.cc View 1 6 chunks +9 lines, -22 lines 0 comments Download
M runtime/include/dart_api.h View 1 3 chunks +25 lines, -28 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 3 chunks +18 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
3 years, 11 months ago (2017-01-06 17:39:52 UTC) #3
siva
lgtm
3 years, 11 months ago (2017-01-12 00:58:13 UTC) #4
rmacnak
3 years, 11 months ago (2017-01-12 17:36:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f51d1b229c5f621e5a5132243ba5604f2a5340de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698