Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 2611333003: [Video] Disable bg optimization if avg keyframe distance is >10s (Closed)
Patch Set: Unittest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl_unittest.cc
diff --git a/media/blink/webmediaplayer_impl_unittest.cc b/media/blink/webmediaplayer_impl_unittest.cc
index cd932032972f2ae4817e9eaf893e3671383c952d..b43567bd99a62f766ff9f8fc55224f1eceb820e5 100644
--- a/media/blink/webmediaplayer_impl_unittest.cc
+++ b/media/blink/webmediaplayer_impl_unittest.cc
@@ -263,6 +263,12 @@ class WebMediaPlayerImplTest : public testing::Test {
return wmpi_->ShouldDisableVideoWhenHidden();
}
+ void SetVideoKeyframeDistanceAverage(base::TimeDelta value) {
+ PipelineStatistics statistics;
+ statistics.video_keyframe_distance_average = value;
+ wmpi_->SetPipelineStatisticsForTest(statistics);
+ }
+
// "Renderer" thread.
base::MessageLoop message_loop_;
@@ -774,18 +780,21 @@ TEST_F(WebMediaPlayerImplTest, ShouldDisableVideoWhenHidden) {
SetMetadata(true, true);
SetBackgroundVideoOptimization(true);
+ SetVideoKeyframeDistanceAverage(base::TimeDelta::FromSeconds(5));
EXPECT_TRUE(ShouldDisableVideoWhenHidden());
- SetMetadata(true, true);
SetBackgroundVideoOptimization(false);
EXPECT_FALSE(ShouldDisableVideoWhenHidden());
- SetMetadata(false, true);
SetBackgroundVideoOptimization(true);
+ SetVideoKeyframeDistanceAverage(base::TimeDelta::FromSeconds(100));
+ EXPECT_FALSE(ShouldDisableVideoWhenHidden());
+
+ SetVideoKeyframeDistanceAverage(base::TimeDelta::FromSeconds(5));
+ SetMetadata(false, true);
EXPECT_FALSE(ShouldDisableVideoWhenHidden());
SetMetadata(true, false);
- SetBackgroundVideoOptimization(true);
EXPECT_FALSE(ShouldDisableVideoWhenHidden());
}

Powered by Google App Engine
This is Rietveld 408576698