Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2611333003: [Video] Disable bg optimization if avg keyframe distance is >10s (Closed)
Patch Set: Changed to TimeDelta Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/blink/webmediaplayer_impl.h ('K') | « media/blink/webmediaplayer_impl.h ('k') | media/filters/decoder_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 4e679e9966b0d38d8727067f1b6869e2e216aa55..d368749a7c31d380635ec5df32a00821aba0ad31 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -2117,9 +2117,16 @@ bool WebMediaPlayerImpl::ShouldPauseWhenHidden() const {
}
bool WebMediaPlayerImpl::ShouldDisableVideoWhenHidden() const {
+ DCHECK(main_task_runner_->BelongsToCurrentThread());
DCHECK(IsHidden());
- return IsBackgroundVideoTrackOptimizationEnabled() && hasVideo() &&
- hasAudio() && !IsStreaming();
+
+ if (!IsBackgroundVideoTrackOptimizationEnabled() || !hasVideo() ||
+ !hasAudio() || IsStreaming())
+ return false;
DaleCurtis 2017/01/11 01:14:51 Multiline if needs {}
whywhat 2017/01/11 17:17:33 Done.
+
+ PipelineStatistics stats = pipeline_.GetStatistics();
+ return stats.video_keyframe_distance_average <
+ max_keyframe_distance_for_fast_decode_;
}
void WebMediaPlayerImpl::EnableVideoTrackIfNeeded() {
« media/blink/webmediaplayer_impl.h ('K') | « media/blink/webmediaplayer_impl.h ('k') | media/filters/decoder_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698