[Video] Disable bg optimization if avg keyframe distance is >10s

media/blink/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <limits>
 #include <string>
@@ skipping 1331 matching lines @@
   if (video_weblayer_)
     video_weblayer_->layer()->SetContentsOpaque(opaque_);
 }
 
 void WebMediaPlayerImpl::OnHidden() {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
   if (watch_time_reporter_)
     watch_time_reporter_->OnHidden();
 
-  if (IsBackgroundVideoTrackOptimizationEnabled()) {
+  if (IsBackgroundVideoTrackOptimizationEnabled() &&
+      ShouldDecodeFastWhenShown()) {
     if (ShouldPauseWhenHidden()) {
       // OnPause() will set |paused_when_hidden_| to false and call
       // UpdatePlayState(), so set the flag to true after and then return.
       OnPause();
       paused_when_hidden_ = true;
       return;
     }
 
     selectedVideoTrackChanged(nullptr);
   }
 
   UpdatePlayState();
 
   // Schedule suspended playing media to be paused if the user doesn't come back
   // to it within some timeout period to avoid any autoplay surprises.
   ScheduleIdlePauseTimer();
 }
 
 void WebMediaPlayerImpl::OnShown() {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
   if (watch_time_reporter_)
     watch_time_reporter_->OnShown();
 
   compositor_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&VideoFrameCompositor::SetForegroundTime,
                  base::Unretained(compositor_), base::TimeTicks::Now()));
 
-  if (IsBackgroundVideoTrackOptimizationEnabled()) {
+  if (IsBackgroundVideoTrackOptimizationEnabled() &&
+      ShouldDecodeFastWhenShown()) {
     if (paused_when_hidden_) {
       paused_when_hidden_ = false;
       OnPlay();  // Calls UpdatePlayState() so return afterwards.
       return;
     }
 
     if (client_->hasSelectedVideoTrack()) {
       WebMediaPlayer::TrackId trackId = client_->getSelectedVideoTrackId();
       selectedVideoTrackChanged(&trackId);
     }
@@ skipping 681 matching lines @@
 
 bool WebMediaPlayerImpl::ShouldPauseWhenHidden() const {
 #if defined(OS_ANDROID)  // WMPI_CAST
   if (isRemote())
     return false;
 #endif  // defined(OS_ANDROID)  // WMPI_CAST
 
   return hasVideo() && !hasAudio();
 }
 
+bool WebMediaPlayerImpl::ShouldDecodeFastWhenShown() const {

[DaleCurtis, 2017/01/09 20:29:54]

This name is very strange. Something like IsVideoSuitableForBackgroundDisable?
would be better. I'd probably just roll it into the
IsBackgroundVideoTrackOptimizationEnabled() function so folk don't need to worry
about two functions when checking.

+  DCHECK(main_task_runner_->BelongsToCurrentThread());
+
+  PipelineStatistics stats = pipeline_.GetStatistics();
+  return stats.video_keyframe_distance_average_ms <
+         max_keyframe_distance_for_fast_decode_.InMilliseconds();
+}
+
 }  // namespace media