Android web notifications: Schedule job instead of starting service (N+)

chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
index cdd6a643be3c3054b82774e90baf14ef7f0cab20..366cb54213206ffa2d8a6cceff00616729325fef 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
@@ -4,6 +4,8 @@
 
 package org.chromium.chrome.browser.notifications;
 
+import android.content.Intent;

[Peter Beverloo, 2017/01/25 18:12:19]

Is this necessary for the documentation link? It's unused otherwise...

[awdf, 2017/01/25 18:23:49]

It's used by the doc link yes (although actually I could have removed the param
and brackets and it would still link to the method.. I am not going to file a
bug for this though :P)

+
 /**
  * Constants used in more than a single Notification class, e.g. intents and extra names.
  */
@@ -23,6 +25,9 @@ public class NotificationConstants {
     /**
      * Names of the Intent extras used for Intents related to notifications. These intents are set
      * and owned by Chromium.
+     *
+     * When adding a new extra, as well as setting it on the intent in NotificationPlatformBridge,
+     * it *must* also be set in {@link NotificationJobService#getJobExtrasFromIntent(Intent)}
      */
     static final String EXTRA_NOTIFICATION_ID = "notification_id";
     static final String EXTRA_NOTIFICATION_INFO_ORIGIN = "notification_info_origin";
@@ -32,6 +37,8 @@ public class NotificationConstants {
     static final String EXTRA_NOTIFICATION_INFO_TAG = "notification_info_tag";
     static final String EXTRA_NOTIFICATION_INFO_ACTION_INDEX = "notification_info_action_index";
     static final String EXTRA_NOTIFICATION_INFO_WEBAPK_PACKAGE = "notification_info_webapk_package";
+    static final String EXTRA_NOTIFICATION_REPLY = "notification_reply";
+    static final String EXTRA_NOTIFICATION_ACTION = "notification_action";
 
     /**
      * Unique identifier for a single sync notification. Since the notification ID is reused,