Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: mojo/edk/test/multiprocess_test_helper.cc

Issue 2611323002: Relanding "Multiprocess test client: Android child process launcher rework." (Closed)
Patch Set: Addressed nyquist@'s comment + sync Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/embedder/platform_channel_pair_posix.cc ('k') | mojo/edk/test/run_all_perftests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/test/multiprocess_test_helper.cc
diff --git a/mojo/edk/test/multiprocess_test_helper.cc b/mojo/edk/test/multiprocess_test_helper.cc
index 9aa9b0c6f7b9ec8c5f3face84c676a6f77993d2f..f5f9ce61a12c8609e0cd5b0b6e0360bb68cb927d 100644
--- a/mojo/edk/test/multiprocess_test_helper.cc
+++ b/mojo/edk/test/multiprocess_test_helper.cc
@@ -182,14 +182,8 @@ int MultiprocessTestHelper::WaitForChildShutdown() {
CHECK(test_child_.IsValid());
int rv = -1;
-#if defined(OS_ANDROID)
- // On Android, we need to use a special function to wait for the child.
- CHECK(AndroidWaitForChildExitWithTimeout(
- test_child_, TestTimeouts::action_timeout(), &rv));
-#else
- CHECK(
- test_child_.WaitForExitWithTimeout(TestTimeouts::action_timeout(), &rv));
-#endif
+ WaitForMultiprocessTestChildExit(test_child_, TestTimeouts::action_timeout(),
+ &rv);
test_child_.Close();
return rv;
}
« no previous file with comments | « mojo/edk/embedder/platform_channel_pair_posix.cc ('k') | mojo/edk/test/run_all_perftests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698