[complier] Enable parallel eager inner function compilation with compiler dispatcher.

src/compiler-dispatcher/compiler-dispatcher.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_DISPATCHER_COMPILER_DISPATCHER_H_
 #define V8_COMPILER_DISPATCHER_COMPILER_DISPATCHER_H_
 
 #include <map>
 #include <memory>
 #include <unordered_set>
@@ skipping 10 matching lines @@
 namespace v8 {
 
 class Platform;
 enum class MemoryPressureLevel;
 
 namespace internal {
 
 class CancelableTaskManager;
 class CompilerDispatcherJob;
 class CompilerDispatcherTracer;
+class CompilationInfo;
+class CompilationJob;
 class Isolate;
+class ParseInfo;
 class SharedFunctionInfo;
+class Zone;
 
 template <typename T>
 class Handle;
 
 // The CompilerDispatcher uses a combination of idle tasks and background tasks
 // to parse and compile lazily parsed functions.
 //
 // As both parsing and compilation currently requires a preparation and
 // finalization step that happens on the main thread, every task has to be
 // advanced during idle time first. Depending on the properties of the task, it
@@ skipping 18 matching lines @@
 // then spins of another idle task to potentially do the final step on the main
 // thread.
 class V8_EXPORT_PRIVATE CompilerDispatcher {
  public:
   enum class BlockingBehavior { kBlock, kDontBlock };
 
   CompilerDispatcher(Isolate* isolate, Platform* platform,
                      size_t max_stack_size);
   ~CompilerDispatcher();
 
-  // Returns true if a job was enqueued.
+  // Returns true if the compiler dispatcher is enabled.
+  bool IsEnabled() const;
+
+  // Enqueue a job for parse and compile. Returns true if a job was enqueued.
   bool Enqueue(Handle<SharedFunctionInfo> function);
 
+  // Enqueue a job for compilation. Function must have already been parsed and
+  // analyzed and be ready for compilation. Takes ownership of |zone|,
+  // |parse_info|, |compile_info| and |job|. Returns true if a job was enqueued.
+  bool Enqueue(Zone* zone, ParseInfo* parse_info, CompilationInfo* compile_info,

[jochen (gone - plz use gerrit), 2017/01/10 09:59:47]

I wonder whether ParseInfo* and Literal* would be enough. The job could then
create the rest it needs from that, no?

[rmcilroy, 2017/01/12 12:31:55]

I've refactored this to only need the SFI*, Literal* and AstValueFactory*, and
have the compiler job create and own the ParseInfo and CompileInfo, which I
think is a much clearer API. WDYT?

+               CompilationJob* job);
+
   // Returns true if there is a pending job for the given function.
   bool IsEnqueued(Handle<SharedFunctionInfo> function) const;
 
   // Blocks until the given function is compiled (and does so as fast as
-  // possible). Returns true if the compile job was succesful.
+  // possible). Returns true if the compile job was successful.
   bool FinishNow(Handle<SharedFunctionInfo> function);
 
+  // Blocks until all enqueued jobs have finished.
+  void FinishAllNow();

[jochen (gone - plz use gerrit), 2017/01/10 09:59:47]

just for the record, I don't think we should have this API long term, but
instead of a shared (ref counted) holder for Zone* and just FinishNow()
individual jobs

[rmcilroy, 2017/01/12 12:31:55]

Agreed, that's going to be my next CL.

+
   // Aborts a given job. Blocks if requested.
   void Abort(Handle<SharedFunctionInfo> function, BlockingBehavior blocking);
 
   // Aborts all jobs. Blocks if requested.
   void AbortAll(BlockingBehavior blocking);
 
   // Memory pressure notifications from the embedder.
   void MemoryPressureNotification(v8::MemoryPressureLevel level,
                                   bool is_isolate_locked);
 
  private:
   FRIEND_TEST(CompilerDispatcherTest, IdleTaskSmallIdleTime);
   FRIEND_TEST(IgnitionCompilerDispatcherTest, CompileOnBackgroundThread);
   FRIEND_TEST(IgnitionCompilerDispatcherTest, FinishNowWithBackgroundTask);
   FRIEND_TEST(IgnitionCompilerDispatcherTest,
               AsyncAbortAllPendingBackgroundTask);
   FRIEND_TEST(IgnitionCompilerDispatcherTest,
               AsyncAbortAllRunningBackgroundTask);
   FRIEND_TEST(IgnitionCompilerDispatcherTest, FinishNowDuringAbortAll);
 
   typedef std::multimap<std::pair<int, int>,
                         std::unique_ptr<CompilerDispatcherJob>>
       JobMap;
   class AbortTask;
   class BackgroundTask;
   class IdleTask;
 
   void WaitForJobIfRunningOnBackground(CompilerDispatcherJob* job);
-  bool IsEnabled() const;
   void AbortInactiveJobs();
+  bool CanEnqueueJobs();
   JobMap::const_iterator GetJobFor(Handle<SharedFunctionInfo> shared) const;
+  bool FinishNow(CompilerDispatcherJob* job);
   void ConsiderJobForBackgroundProcessing(CompilerDispatcherJob* job);
   void ScheduleMoreBackgroundTasksIfNeeded();
   void ScheduleIdleTaskFromAnyThread();
   void ScheduleIdleTaskIfNeeded();
   void ScheduleAbortTask();
   void DoBackgroundWork();
   void DoIdleWork(double deadline_in_seconds);
 
   Isolate* isolate_;
   Platform* platform_;
@@ skipping 40 matching lines @@
   base::AtomicValue<bool> block_for_testing_;
   base::Semaphore semaphore_for_testing_;
 
   DISALLOW_COPY_AND_ASSIGN(CompilerDispatcher);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_DISPATCHER_COMPILER_DISPATCHER_H_