Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 26113002: Move core/platform/text/Locale* to platform/text (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Move core/platform/text/Locale* to platform/text I pulled on a few strands, and I ended up moving the Locale code into blink_platform.dll. TBR=eseidel@chromium.org BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158983

Patch Set 1 #

Patch Set 2 : Actually includes the CL #

Patch Set 3 : Re-upload #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -3233 lines) Patch
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/core.gyp View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 5 chunks +1 line, -14 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/dom/TreeShared.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/forms/BaseDateAndTimeInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/CheckboxInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/forms/DateInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/EmailInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/MonthInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/RadioInputType.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/ResetInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/SubmitInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TimeInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/URLInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/WeekInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLParserThread.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DateTimeNumericFieldElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PagePopupController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/SSLKeyGenerator.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/platform/StatsCounter.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/platform/Task.h View 1 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/platform/TreeShared.h View 1 1 chunk +0 lines, -123 lines 0 comments Download
D Source/core/platform/chromium/SSLKeyGeneratorChromium.cpp View 1 1 chunk +0 lines, -56 lines 0 comments Download
Source/core/platform/chromium/StatsCounterChromium.cpp View 1 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/platform/text/LocaleICU.h View 1 1 chunk +0 lines, -117 lines 0 comments Download
D Source/core/platform/text/LocaleICU.cpp View 1 1 chunk +0 lines, -434 lines 0 comments Download
D Source/core/platform/text/LocaleMac.h View 1 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/platform/text/LocaleMac.mm View 1 1 chunk +0 lines, -332 lines 0 comments Download
D Source/core/platform/text/LocaleToScriptMapping.h View 1 1 chunk +0 lines, -44 lines 0 comments Download
D Source/core/platform/text/LocaleToScriptMappingDefault.cpp View 1 1 chunk +0 lines, -404 lines 0 comments Download
D Source/core/platform/text/LocaleWin.h View 1 1 chunk +0 lines, -101 lines 0 comments Download
D Source/core/platform/text/LocaleWin.cpp View 1 1 chunk +0 lines, -592 lines 0 comments Download
D Source/core/platform/text/PlatformLocale.h View 1 1 chunk +0 lines, -172 lines 0 comments Download
D Source/core/platform/text/PlatformLocale.cpp View 1 1 chunk +0 lines, -419 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGElementInstance.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AsyncAudioDecoder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/SSLKeyGenerator.h View 1 1 chunk +11 lines, -10 lines 0 comments Download
A + Source/platform/SSLKeyGenerator.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
A + Source/platform/Task.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gyp View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
A + Source/platform/text/LocaleICU.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/platform/text/LocaleICU.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/text/LocaleMac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/platform/text/LocaleMac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/text/LocaleToScriptMapping.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + Source/platform/text/LocaleToScriptMapping.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/text/LocaleWin.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/platform/text/LocaleWin.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/platform/text/PlatformLocale.h View 1 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/text/PlatformLocale.cpp View 1 7 chunks +15 lines, -13 lines 0 comments Download
M Source/web/ColorChooserUIController.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/tests/LocaleICUTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/LocaleMacTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/LocaleWinTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
7 years, 2 months ago (2013-10-05 07:00:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26113002/7001
7 years, 2 months ago (2013-10-05 07:19:11 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Document.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-05 07:19:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26113002/11001
7 years, 2 months ago (2013-10-05 07:24:28 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-05 08:52:06 UTC) #5
Message was sent while issue was closed.
Change committed as 158983

Powered by Google App Engine
This is Rietveld 408576698