Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 2611283002: [mojo talk demo] Convert utility process CheckMediaFile IPC to mojo (Closed)

Created:
3 years, 11 months ago by Noel Gordon
Modified:
3 years, 11 months ago
Reviewers:
tibell
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, tommycli, posciak+watch_chromium.org, tzik, viettrungluu+watch_chromium.org, nhiroki, abarth-chromium, Lei Zhang, yzshen+watch_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), kinuko+fileapi, Aaron Boodman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo talk demo] Convert utility process CheckMediaFile IPC to mojo Covered by browser tests MediaFileValidatorTest.ValidVideo and MediaFileValidatorTest.ValidAudio (omg, this one has tests!). BUG=680928

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -52 lines) Patch
M chrome/browser/chrome_content_utility_manifest_overlay.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc View 1 4 chunks +12 lines, -16 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/common/extensions/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/chrome_utility_extensions_messages.h View 2 chunks +0 lines, -13 lines 0 comments Download
A chrome/common/extensions/media_parser.mojom View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 5 chunks +48 lines, -16 lines 0 comments Download

Messages

Total messages: 19 (17 generated)
Noel Gordon
This one was used for the mojo talk demo. I moved the work to https://codereview.chromium.org/2639503002 ...
3 years, 11 months ago (2017-01-19 05:27:10 UTC) #16
Noel Gordon
3 years, 11 months ago (2017-01-19 10:44:29 UTC) #18
On 2017/01/19 05:27:10, noel gordon wrote:
> This one was used for the mojo talk demo.  I moved the work to
> https://codereview.chromium.org/2639503002 and should keep this one around,
say
> if you wanted to demo it again?

Anyho, let me know.

Powered by Google App Engine
This is Rietveld 408576698