[Payment Request] Change the lifetime management of PaymentRequestImpl

components/payments/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//mojo/public/tools/bindings/mojom.gni")
 
 mojom("payment_request") {
   sources = [
     "payment_request.mojom",
   ]
 
   public_deps = [
     "//mojo/common:common_custom_types",
   ]
 }
 
 mojom("payment_app") {
   sources = [
     "payment_app.mojom",
   ]
 
   public_deps = [
     "//mojo/common:common_custom_types",
   ]
 }
 
+static_library("payment_request_impl") {
+  sources = [
+    "payment_request_delegate.h",
+    "payment_request_impl.cc",
+    "payment_request_impl.h",
+    "payment_request_web_contents_manager.cc",
+    "payment_request_web_contents_manager.h",
+  ]
+
+  deps = [
+    ":payment_request",
+    ":payment_validation",
+    "//content/public/browser",

[sdefresne, 2017/01/09 16:38:47]

If components/payments/BUILD.gn is loaded on iOS then you'll get error when
running "gn check" as this will cause "//content/public/browser" to be loaded on
iOS even if no iOS target depends on this one (this is because every target
visible from a BUILD.gn file is instantiated and buildable via ninja even if
there is no direct dependency from //).

The quick solution to fix this is to put this target behind if (!is_ios):

if (!is_ios) {
  static_library(....) {
  }
}

But the correct solution is instead to change payments component to be a
layered-component (see
https://www.chromium.org/developers/design-documents/layered-components-design)
as DEPS are not fine grained enough.

That is move all files currently in component/payments to
component/payments/core and move the new files to components/payments/content.

+    "//mojo/public/cpp/bindings",
+  ]
+}
+
 static_library("payment_validation") {
   sources = [
     "payment_details_validation.cc",
     "payment_details_validation.h",
     "payments_validators.cc",
     "payments_validators.h",
   ]
 
   deps = [
     ":payment_request",
     "//base",
     "//third_party/re2:re2",
     "//url:url",
   ]
 }
 
 static_library("unit_tests") {
   testonly = true
   sources = [
     "payments_validators_test.cc",
   ]
 
   deps = [
     ":payment_validation",
     "//testing/gtest",
   ]
 }