components/payments/payment_request_delegate.h - Issue 2611253004: [Payment Request] Change the lifetime management of PaymentRequestImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/payments/payment_request_delegate.h

Issue 2611253004: [Payment Request] Change the lifetime management of PaymentRequestImpl (Closed)

Patch Set: added a browser test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/payments/site_per_process_payments_browsertest.cc ('K') | « components/payments/DEPS ('k') | components/payments/payment_request_impl.h » ('j') | components/payments/payment_request_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	please use gerrit instead 2017/01/06 21:49:09 2017 2017 Mathieu 2017/01/07 05:03:07 Done. Show quoted text On 2017/01/06 21:49:09, rouslan wrote: > 2017 Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_PAYMENTS_PAYMENT_REQUEST_DELEGATE_H_

	6 #define COMPONENTS_PAYMENTS_PAYMENT_REQUEST_DELEGATE_H_

	7

	8 namespace payments {

	9

	10 class PaymentRequestImpl;

	11

	12 class PaymentRequestDelegate {

	13 public:

	14 virtual void ShowPaymentRequestDialog(PaymentRequestImpl* impl) = 0;
	please use gerrit instead 2017/01/06 21:49:09 Need a virtual destructor with empty body: "To ma Need a virtual destructor with empty body: "To make sure all implementations of the interface can be destroyed correctly, the interface must also declare a virtual destructor (in an exception to the first rule, this should not be pure). See Stroustrup, The C++ Programming Language, 3rd edition, section 12.4 for details." https://google.github.io/styleguide/cppguide.html#Interfaces Mathieu 2017/01/07 05:03:07 Done. Show quoted text On 2017/01/06 21:49:09, rouslan wrote: > Need a virtual destructor with empty body: > > "To make sure all implementations of the interface can be destroyed correctly, > the interface must also declare a virtual destructor (in an exception to the > first rule, this should not be pure). See Stroustrup, The C++ Programming > Language, 3rd edition, section 12.4 for details." > > https://google.github.io/styleguide/cppguide.html#Interfaces Done.
	15 };

	16

	17 } // namespace payments

	18

	19 #endif // COMPONENTS_PAYMENTS_PAYMENT_REQUEST_DELEGATE_H_

OLD	NEW