chrome/browser/payments/chrome_payment_request_delegate.h - Issue 2611253004: [Payment Request] Change the lifetime management of PaymentRequestImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/payments/chrome_payment_request_delegate.h

Issue 2611253004: [Payment Request] Change the lifetime management of PaymentRequestImpl (Closed)

Patch Set: added a browser test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	please use gerrit instead 2017/01/06 21:49:09 2017 2017
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PAYMENTS_CHROME_PAYMENT_REQUEST_DELEGATE_H_

	6 #define CHROME_BROWSER_PAYMENTS_CHROME_PAYMENT_REQUEST_DELEGATE_H_

	7

	8 #include "components/payments/payment_request_delegate.h"

	9

	10 namespace payments {

	11

	12 class PaymentRequestImpl;

	13

	14 class ChromePaymentRequestDelegate : public PaymentRequestDelegate {

	15 public:

	16 void ShowPaymentRequestDialog(PaymentRequestImpl* impl) override;

	17 };
	please use gerrit instead 2017/01/06 21:49:09 private: DISALLOW_COPY_AND_ASSIGN(ChromePaymentR private: DISALLOW_COPY_AND_ASSIGN(ChromePaymentRequestDelegate); (from "base/macros.h") please use gerrit instead 2017/01/06 21:49:09 Need to override the destructor from PaymentReques Need to override the destructor from PaymentRequestDelegate.
	18

	19 } // namespace payments

	20

	21 #endif // CHROME_BROWSER_PAYMENTS_CHROME_PAYMENT_REQUEST_DELEGATE_H_

OLD	NEW