chrome/browser/payments/chrome_payment_request_delegate.cc - Issue 2611253004: [Payment Request] Change the lifetime management of PaymentRequestImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/payments/chrome_payment_request_delegate.cc

Issue 2611253004: [Payment Request] Change the lifetime management of PaymentRequestImpl (Closed)

Patch Set: added a browser test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	please use gerrit instead 2017/01/06 21:49:09 2017 2017 Mathieu 2017/01/07 05:03:07 Done. Show quoted text On 2017/01/06 21:49:09, rouslan wrote: > 2017 Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/payments/chrome_payment_request_delegate.h"

	6

	7 #include "chrome/browser/ui/browser_dialogs.h"

	8 #include "components/payments/payment_request_impl.h"
	please use gerrit instead 2017/01/06 21:49:09 May not need to include payment_request_impl.h. Fo May not need to include payment_request_impl.h. Forward declaration of PaymentRequestImpl class in the corresponding header file was sufficient, I think. Mathieu 2017/01/07 05:03:07 Done. Show quoted text On 2017/01/06 21:49:09, rouslan wrote: > May not need to include payment_request_impl.h. Forward declaration of > PaymentRequestImpl class in the corresponding header file was sufficient, I > think. Done.
	9

	10 namespace payments {

	11

	12 void ChromePaymentRequestDelegate::ShowPaymentRequestDialog(

	13 PaymentRequestImpl* impl) {

	14 chrome::ShowPaymentRequestDialog(impl);

	15 }

	16

	17 } // namespace payments

OLD	NEW