Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerTest.cpp

Issue 2611233003: When setting needsRepaint, don't stop at non-stacking composited PaintLayers. (Closed)
Patch Set: none Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp b/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
index 5804a8c665085f419ecfd4a3775289a325fcd999..2d4ca9cebae40cf60b1f4ed03adb5414bda92e0c 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
@@ -498,4 +498,22 @@ TEST_P(PaintLayerTest, PaintInvalidationOnCompositedScroll) {
EXPECT_EQ(LayoutRect(0, 30, 50, 5), content->visualRect());
}
+TEST_P(PaintLayerTest, CompositingContainerFloat) {
+ enableCompositing();
+ setBodyInnerHTML(
+ "<div id='containingBlock' style='position: relative; z-index: 0'>"
+ "<div style='backface-visibility: hidden'></div>"
Xianzhu 2017/01/07 01:04:46 Nit: indent line 505-508 by 2 spaces after '"'.
chrishtr 2017/01/07 01:15:00 Fixed.
+ "<span style='clip-path: polygon(0px 15px, 0px 54px, 100px 0px)'>"
+ " <div id='target' style='float: right; position: relative'></div>"
+ "</span>"
+ "</html>");
Xianzhu 2017/01/07 01:04:46 Nit: s/html/div/
chrishtr 2017/01/07 01:15:00 Fixed.
+
+ PaintLayer* target =
+ toLayoutBoxModelObject(getLayoutObjectByElementId("target"))->layer();
+ PaintLayer* containingBlock =
+ toLayoutBoxModelObject(getLayoutObjectByElementId("containingBlock"))
+ ->layer();
+ EXPECT_EQ(containingBlock, target->compositingContainer());
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698