PlzNavigate: Fix for the http/tests/inspector/resource-har-conversion.html layout test failure.

third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 209 matching lines @@
   Response getCertificate(
       const String& origin,
       std::unique_ptr<protocol::Array<String>>* certificate) override;
 
   // Called from other agents.
   void setHostId(const String&);
   bool fetchResourceContent(Document*,
                             const KURL&,
                             String* content,
                             bool* base64Encoded);
+  bool cacheDisabled();

[pfeldman, 2017/01/09 16:40:41]

Any reason for exposing it here instead of adding a bit into
WebFrameClient::NavigationPolicyInfo in decidePolicyForNavigation? That would
look more consistent with the rest of the plumbing.

[ananta, 2017/01/10 01:20:09]

The setCacheDisabled function in the InspectorNetworkAgent class is called via
an IPC message DevToolsAgentMsg_DispatchOnInspectorBackend which is sent from
the browser
https://cs.chromium.org/chromium/src/content/browser/devtools/worker_devtools...

That function sets a state variable internally. We need the getter function to
query this state.

I left the function as is. I added a flag isCacheDisabled to the
NavigationPolicyInfo structure. This is set in
FrameLoaderClientImpl::decidePolicyForNavigation. We use this flag to determine
whether to turn off caching for the request.

Thanks

 
  private:
   explicit InspectorNetworkAgent(InspectedFrames*);
 
   void enable(int totalBufferSize, int resourceBufferSize);
   void willSendRequestInternal(LocalFrame*,
                                unsigned long identifier,
                                DocumentLoader*,
                                const ResourceRequest&,
                                const ResourceResponse& redirectResponse,
@@ skipping 38 matching lines @@
   bool m_isRecalculatingStyle;
 
   HeapHashSet<Member<XMLHttpRequest>> m_replayXHRs;
   HeapHashSet<Member<XMLHttpRequest>> m_replayXHRsToBeDeleted;
   Timer<InspectorNetworkAgent> m_removeFinishedReplayXHRTimer;
 };
 
 }  // namespace blink
 
 #endif  // !defined(InspectorNetworkAgent_h)