Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/objects-inl.h

Issue 2611063002: [class fields] Remove a bit of dead code leftover from cleanup (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/parsing/parse-info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6205 matching lines...) Expand 10 before | Expand all | Expand 10 after
6216 name_should_print_as_anonymous, 6216 name_should_print_as_anonymous,
6217 kNameShouldPrintAsAnonymous) 6217 kNameShouldPrintAsAnonymous)
6218 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_anonymous_expression, 6218 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_anonymous_expression,
6219 kIsAnonymousExpression) 6219 kIsAnonymousExpression)
6220 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_function, kIsFunction) 6220 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_function, kIsFunction)
6221 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, must_use_ignition_turbo, 6221 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, must_use_ignition_turbo,
6222 kMustUseIgnitionTurbo) 6222 kMustUseIgnitionTurbo)
6223 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush) 6223 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush)
6224 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_asm_wasm_broken, 6224 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_asm_wasm_broken,
6225 kIsAsmWasmBroken) 6225 kIsAsmWasmBroken)
6226 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, requires_class_field_init,
6227 kRequiresClassFieldInit)
6228 BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_class_field_initializer,
6229 kIsClassFieldInitializer)
6230 6226
6231 bool Script::HasValidSource() { 6227 bool Script::HasValidSource() {
6232 Object* src = this->source(); 6228 Object* src = this->source();
6233 if (!src->IsString()) return true; 6229 if (!src->IsString()) return true;
6234 String* src_str = String::cast(src); 6230 String* src_str = String::cast(src);
6235 if (!StringShape(src_str).IsExternal()) return true; 6231 if (!StringShape(src_str).IsExternal()) return true;
6236 if (src_str->IsOneByteRepresentation()) { 6232 if (src_str->IsOneByteRepresentation()) {
6237 return ExternalOneByteString::cast(src)->resource() != NULL; 6233 return ExternalOneByteString::cast(src)->resource() != NULL;
6238 } else if (src_str->IsTwoByteRepresentation()) { 6234 } else if (src_str->IsTwoByteRepresentation()) {
6239 return ExternalTwoByteString::cast(src)->resource() != NULL; 6235 return ExternalTwoByteString::cast(src)->resource() != NULL;
(...skipping 2215 matching lines...) Expand 10 before | Expand all | Expand 10 after
8455 #undef WRITE_INT64_FIELD 8451 #undef WRITE_INT64_FIELD
8456 #undef READ_BYTE_FIELD 8452 #undef READ_BYTE_FIELD
8457 #undef WRITE_BYTE_FIELD 8453 #undef WRITE_BYTE_FIELD
8458 #undef NOBARRIER_READ_BYTE_FIELD 8454 #undef NOBARRIER_READ_BYTE_FIELD
8459 #undef NOBARRIER_WRITE_BYTE_FIELD 8455 #undef NOBARRIER_WRITE_BYTE_FIELD
8460 8456
8461 } // namespace internal 8457 } // namespace internal
8462 } // namespace v8 8458 } // namespace v8
8463 8459
8464 #endif // V8_OBJECTS_INL_H_ 8460 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/parsing/parse-info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698