filter out .caller from other worlds

filter out .caller from  other worlds

R=verwaest@chromium.org

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=21366

[dcarney, 2014-05-02 12:35:01]

ptal

[Toon Verwaest, 2014-05-05 15:16:38]

lgtm

[yurys, 2014-05-19 08:30:04]

https://codereview.chromium.org/261103002/diff/20001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/261103002/diff/20001/src/isolate.cc#newcode494
src/isolate.cc:494: if
(!this->context()->HasSameSecurityTokenAs(fun->context())) continue;
This change breaks DevTools debugger as e.g. when paused on exception we will
get empty call stack and based on that will treat the exception as syntax error.
See
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[dcarney, 2014-05-19 09:33:16]

thanks for looking into this for me yury, i'll work towards landing this soon

https://codereview.chromium.org/261103002/diff/20001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/261103002/diff/20001/src/isolate.cc#newcode494
src/isolate.cc:494: if
(!this->context()->HasSameSecurityTokenAs(fun->context())) continue;
On 2014/05/19 08:30:04, yurys wrote:
> This change breaks DevTools debugger as e.g. when paused on exception we will
> get empty call stack and based on that will treat the exception as syntax
error.
> See

got it.  luckily, scriptdebugserver is written in c++, so i'll add a
StackTraceOptions value to disable the filtering.  we are only trying to filter
js accesses at the moment here

[yurys, 2014-05-19 12:51:41]

https://codereview.chromium.org/261103002/diff/100001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/261103002/diff/100001/src/api.cc#newcode2119
src/api.cc:2119: options = static_cast<StackTraceOptions>(
You could do this in one step, by updating
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
as part of next v8 roll.

[dcarney, 2014-05-19 13:38:44]

On 2014/05/19 12:51:41, yurys wrote:
> https://codereview.chromium.org/261103002/diff/100001/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/261103002/diff/100001/src/api.cc#newcode2119
> src/api.cc:2119: options = static_cast<StackTraceOptions>(
> You could do this in one step, by updating
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> as part of next v8 roll.

maybe, but i'm hoping it can be used for ScriptDebugServer only.  I think the
other places don't need it/shouldn't have it, but I haven't confirmed this yet.

[dcarney, 2014-05-19 13:45:54]

Committed patchset #7 manually as r21366 (presubmit successful).