Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: cc/trees/layer_tree_impl.cc

Issue 2611013002: Show Overlay Scrollbar when GestureScrollUpdate (Closed)
Patch Set: bokan comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_impl.h" 5 #include "cc/trees/layer_tree_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 235
236 gfx::ScrollOffset current_offset = scroll_layer->CurrentScrollOffset(); 236 gfx::ScrollOffset current_offset = scroll_layer->CurrentScrollOffset();
237 if (IsViewportLayerId(scroll_layer_id)) { 237 if (IsViewportLayerId(scroll_layer_id)) {
238 current_offset += InnerViewportScrollLayer()->CurrentScrollOffset(); 238 current_offset += InnerViewportScrollLayer()->CurrentScrollOffset();
239 if (OuterViewportContainerLayer()) 239 if (OuterViewportContainerLayer())
240 clip_size.SetToMin(OuterViewportContainerLayer()->BoundsForScrolling()); 240 clip_size.SetToMin(OuterViewportContainerLayer()->BoundsForScrolling());
241 clip_size.Scale(1 / current_page_scale_factor()); 241 clip_size.Scale(1 / current_page_scale_factor());
242 } 242 }
243 243
244 bool scrollbar_needs_animation = false; 244 bool scrollbar_needs_animation = false;
245 bool clip_layer_size_did_change = false;
245 bool scroll_layer_size_did_change = false; 246 bool scroll_layer_size_did_change = false;
246 bool y_offset_did_change = false; 247 bool y_offset_did_change = false;
247 for (ScrollbarLayerImplBase* scrollbar : ScrollbarsFor(scroll_layer_id)) { 248 for (ScrollbarLayerImplBase* scrollbar : ScrollbarsFor(scroll_layer_id)) {
248 if (scrollbar->orientation() == HORIZONTAL) { 249 if (scrollbar->orientation() == HORIZONTAL) {
249 scrollbar_needs_animation |= scrollbar->SetCurrentPos(current_offset.x()); 250 scrollbar_needs_animation |= scrollbar->SetCurrentPos(current_offset.x());
250 scrollbar_needs_animation |= 251 scrollbar_needs_animation |= clip_layer_size_did_change |=
251 scrollbar->SetClipLayerLength(clip_size.width()); 252 scrollbar->SetClipLayerLength(clip_size.width());
252 scrollbar_needs_animation |= scroll_layer_size_did_change |= 253 scrollbar_needs_animation |= scroll_layer_size_did_change |=
253 scrollbar->SetScrollLayerLength(scroll_size.width()); 254 scrollbar->SetScrollLayerLength(scroll_size.width());
254 } else { 255 } else {
255 scrollbar_needs_animation |= y_offset_did_change |= 256 scrollbar_needs_animation |= y_offset_did_change |=
256 scrollbar->SetCurrentPos(current_offset.y()); 257 scrollbar->SetCurrentPos(current_offset.y());
257 scrollbar_needs_animation |= 258 scrollbar_needs_animation |= clip_layer_size_did_change |=
258 scrollbar->SetClipLayerLength(clip_size.height()); 259 scrollbar->SetClipLayerLength(clip_size.height());
259 scrollbar_needs_animation |= scroll_layer_size_did_change |= 260 scrollbar_needs_animation |= scroll_layer_size_did_change |=
260 scrollbar->SetScrollLayerLength(scroll_size.height()); 261 scrollbar->SetScrollLayerLength(scroll_size.height());
261 } 262 }
262 scrollbar_needs_animation |= 263 scrollbar_needs_animation |=
263 scrollbar->SetVerticalAdjust(clip_layer->bounds_delta().y()); 264 scrollbar->SetVerticalAdjust(clip_layer->bounds_delta().y());
264 } 265 }
265 266
266 if (y_offset_did_change && IsViewportLayerId(scroll_layer_id)) 267 if (y_offset_did_change && IsViewportLayerId(scroll_layer_id))
267 TRACE_COUNTER_ID1("cc", "scroll_offset_y", scroll_layer->id(), 268 TRACE_COUNTER_ID1("cc", "scroll_offset_y", scroll_layer->id(),
268 current_offset.y()); 269 current_offset.y());
269 270
270 if (scrollbar_needs_animation) { 271 if (scrollbar_needs_animation) {
271 ScrollbarAnimationController* controller = 272 ScrollbarAnimationController* controller =
272 layer_tree_host_impl_->ScrollbarAnimationControllerForId( 273 layer_tree_host_impl_->ScrollbarAnimationControllerForId(
273 scroll_layer_id); 274 scroll_layer_id);
274 if (controller) 275 if (!controller)
275 controller->DidScrollUpdate(scroll_layer_size_did_change); 276 return;
277
278 if (clip_layer_size_did_change || scroll_layer_size_did_change) {
279 controller->DidResize();
280 } else {
281 controller->WillUpdateScroll();
282 }
276 } 283 }
277 } 284 }
278 285
279 RenderSurfaceImpl* LayerTreeImpl::RootRenderSurface() const { 286 RenderSurfaceImpl* LayerTreeImpl::RootRenderSurface() const {
280 return layer_list_.empty() ? nullptr : layer_list_[0]->GetRenderSurface(); 287 return layer_list_.empty() ? nullptr : layer_list_[0]->GetRenderSurface();
281 } 288 }
282 289
283 bool LayerTreeImpl::LayerListIsEmpty() const { 290 bool LayerTreeImpl::LayerListIsEmpty() const {
284 return layer_list_.empty(); 291 return layer_list_.empty();
285 } 292 }
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
1022 LayerTreeHostCommon::CalcDrawPropsImplInputs inputs( 1029 LayerTreeHostCommon::CalcDrawPropsImplInputs inputs(
1023 layer_list_[0], DrawViewportSize(), 1030 layer_list_[0], DrawViewportSize(),
1024 layer_tree_host_impl_->DrawTransform(), device_scale_factor(), 1031 layer_tree_host_impl_->DrawTransform(), device_scale_factor(),
1025 current_page_scale_factor(), PageScaleLayer(), 1032 current_page_scale_factor(), PageScaleLayer(),
1026 InnerViewportScrollLayer(), OuterViewportScrollLayer(), 1033 InnerViewportScrollLayer(), OuterViewportScrollLayer(),
1027 elastic_overscroll()->Current(IsActiveTree()), 1034 elastic_overscroll()->Current(IsActiveTree()),
1028 OverscrollElasticityLayer(), resource_provider()->max_texture_size(), 1035 OverscrollElasticityLayer(), resource_provider()->max_texture_size(),
1029 can_render_to_separate_surface, 1036 can_render_to_separate_surface,
1030 settings().layer_transforms_should_scale_layer_contents, 1037 settings().layer_transforms_should_scale_layer_contents,
1031 settings().verify_clip_tree_calculations, 1038 settings().verify_clip_tree_calculations,
1032 verify_visible_rect_calculations, 1039 verify_visible_rect_calculations, &render_surface_layer_list_,
1033 &render_surface_layer_list_, &property_trees_); 1040 &property_trees_);
1034 LayerTreeHostCommon::CalculateDrawProperties(&inputs); 1041 LayerTreeHostCommon::CalculateDrawProperties(&inputs);
1035 if (const char* client_name = GetClientNameForMetrics()) { 1042 if (const char* client_name = GetClientNameForMetrics()) {
1036 UMA_HISTOGRAM_COUNTS( 1043 UMA_HISTOGRAM_COUNTS(
1037 base::StringPrintf( 1044 base::StringPrintf(
1038 "Compositing.%s.LayerTreeImpl.CalculateDrawPropertiesUs", 1045 "Compositing.%s.LayerTreeImpl.CalculateDrawPropertiesUs",
1039 client_name), 1046 client_name),
1040 timer.Elapsed().InMicroseconds()); 1047 timer.Elapsed().InMicroseconds());
1041 UMA_HISTOGRAM_COUNTS_100( 1048 UMA_HISTOGRAM_COUNTS_100(
1042 base::StringPrintf("Compositing.%s.NumRenderSurfaces", client_name), 1049 base::StringPrintf("Compositing.%s.NumRenderSurfaces", client_name),
1043 base::saturated_cast<int>(render_surface_layer_list_.size())); 1050 base::saturated_cast<int>(render_surface_layer_list_.size()));
(...skipping 1078 matching lines...) Expand 10 before | Expand all | Expand 10 after
2122 2129
2123 void LayerTreeImpl::ResetAllChangeTracking() { 2130 void LayerTreeImpl::ResetAllChangeTracking() {
2124 layers_that_should_push_properties_.clear(); 2131 layers_that_should_push_properties_.clear();
2125 // Iterate over all layers, including masks. 2132 // Iterate over all layers, including masks.
2126 for (auto& layer : *layers_) 2133 for (auto& layer : *layers_)
2127 layer->ResetChangeTracking(); 2134 layer->ResetChangeTracking();
2128 property_trees_.ResetAllChangeTracking(); 2135 property_trees_.ResetAllChangeTracking();
2129 } 2136 }
2130 2137
2131 } // namespace cc 2138 } // namespace cc
OLDNEW
« cc/trees/layer_tree_host_impl_unittest.cc ('K') | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698