Issue 26110008: Fix handling of tests that fail two different ways in run-webkit-tests (buildbot side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26110008: Fix handling of tests that fail two different ways in run-webkit-tests (buildbot side) (Closed)

Created:
7 years, 2 months ago by Dirk Pranke

Modified:
7 years, 2 months ago

Reviewers:
Isaac (away), ojan

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix handling of tests that fail two different ways in run-webkit-tests (buildbot side). This is a follow-on to r159630. It turns out I wasn't covering the case where a test fails two different ways, and the second failure is actually an expected failure. TBR=ilevy@chromium.org, ojan@chromium.org BUG=307277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230204

Patch Set 1 #

Patch Set 2 : rietveld!! #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		1 chunk	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/26110008/12001

7 years, 2 months ago (2013-10-18 00:35:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/26110008/12001

7 years, 2 months ago (2013-10-18 01:20:55 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=31287

7 years, 2 months ago (2013-10-18 19:42:14 UTC) #4

Dirk Pranke

7 years, 2 months ago (2013-10-22 21:13:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r230204 (presubmit successful).

Expand Messages | Collapse Messages