LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html - Issue 26110004: Defer the real work in updateCompositingLayers until it's really needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html

Issue 26110004: Defer the real work in updateCompositingLayers until it's really needed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed reviewer feedback about inspector error check Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js ('k') | LayoutTests/http/tests/inspector/inspector-test.js » ('j') | Source/core/page/Page.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html

diff --git a/LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html b/LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html

index 95c96cc90b8bfed7445964fdae399c0e3e8ae8c9..c306c510aeadf82579b6ced6c054d0525358b043 100644

--- a/LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html

+++ b/LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html

@@ -25,8 +25,12 @@

var layer = document.getElementById('layer');

layer.addEventListener('touchstart', function() {});

- // Ensure we've done a layout and we have a hit rect on this composited layer.

+ // Ensure we've done a layout, updated compositing, and we have a hit rect on this composited layer.

var x = layer.offsetTop;

+ if (window.internals)

+ window.internals.forceCompositingUpdate(document);

var rects;

if (window.internals) {

rects = window.internals.touchEventTargetLayerRects(document);