Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js

Issue 2610963005: [DevTools] Pass the frame payload (Closed)
Patch Set: [DevTools] Pass the frame payload Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
index 2b0b903fa3fe02e5b361a455438be235710cca3b..dd5ce78cf40e4b9633288daf85f08b21e36a9e37 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js
@@ -11,7 +11,7 @@ SDK.SecurityOriginManager = class extends SDK.SDKModel {
constructor(target) {
super(SDK.SecurityOriginManager, target);
- this._securityOriginCounter = new Map();
+ this._securityOrigins = new Set();
pfeldman 2017/01/09 20:06:13 Please annotate type (Set of strings)
eostroukhov 2017/01/09 20:32:01 Done.
this._mainSecurityOrigin = '';
}
@@ -26,37 +26,26 @@ SDK.SecurityOriginManager = class extends SDK.SDKModel {
return securityOriginManager;
}
- /**
- * @param {string} securityOrigin
- */
- addSecurityOrigin(securityOrigin) {
- var currentCount = this._securityOriginCounter.get(securityOrigin);
- if (!currentCount) {
- this._securityOriginCounter.set(securityOrigin, 1);
- this.dispatchEventToListeners(SDK.SecurityOriginManager.Events.SecurityOriginAdded, securityOrigin);
- return;
+ updateSecurityOrigins(securityOrigins) {
pfeldman 2017/01/09 20:06:13 Please annotate securityOrigins type, should be Se
eostroukhov 2017/01/09 20:32:01 Done.
+ var oldOrigins = this._securityOrigins;
+ this._securityOrigins = new Set(securityOrigins);
+
+ for (var origin of oldOrigins) {
+ if (!this._securityOrigins.has(origin))
+ this.dispatchEventToListeners(SDK.SecurityOriginManager.Events.SecurityOriginRemoved, origin);
}
- this._securityOriginCounter.set(securityOrigin, currentCount + 1);
- }
- /**
- * @param {string} securityOrigin
- */
- removeSecurityOrigin(securityOrigin) {
- var currentCount = this._securityOriginCounter.get(securityOrigin);
- if (currentCount === 1) {
- this._securityOriginCounter.delete(securityOrigin);
- this.dispatchEventToListeners(SDK.SecurityOriginManager.Events.SecurityOriginRemoved, securityOrigin);
- return;
+ for (var origin of this._securityOrigins) {
+ if (!oldOrigins.has(origin))
+ this.dispatchEventToListeners(SDK.SecurityOriginManager.Events.SecurityOriginAdded, origin);
}
- this._securityOriginCounter.set(securityOrigin, currentCount - 1);
}
/**
* @return {!Array<string>}
*/
securityOrigins() {
- return this._securityOriginCounter.keysArray();
+ return this._securityOrigins.valuesArray();
}
/**

Powered by Google App Engine
This is Rietveld 408576698