Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2610963003: Get rid of obsolete FrameView::m_shouldUpdateViewportIntersection. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index b9b322be5b1dbb6d6cfec3aee598b8d28b9381ab..eabfa583adb0967c42900f852f194b0f2899201e 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -175,7 +175,6 @@ FrameView::FrameView(LocalFrame& frame)
m_didScrollTimer(this, &FrameView::didScrollTimerFired),
m_browserControlsViewportAdjustment(0),
m_needsUpdateWidgetGeometries(false),
- m_needsUpdateViewportIntersection(true),
#if ENABLE(ASSERT)
m_hasBeenDisposed(false),
#endif
@@ -3584,7 +3583,6 @@ void FrameView::setParent(Widget* parentView) {
Widget::setParent(parentView);
updateParentScrollableAreaSet();
- setNeedsUpdateViewportIntersection();
setupRenderThrottling();
if (parentFrameView())
@@ -3635,7 +3633,6 @@ void FrameView::frameRectsChanged() {
if (layoutSizeFixedToFrameSize())
setLayoutSizeInternal(frameRect().size());
- setNeedsUpdateViewportIntersection();
if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
// The overflow clip property depends on the frame rect.
setNeedsPaintPropertyUpdate();
@@ -4550,12 +4547,6 @@ void FrameView::collectAnnotatedRegions(
collectAnnotatedRegions(*curr, regions);
}
-void FrameView::setNeedsUpdateViewportIntersection() {
- for (FrameView* parent = parentFrameView(); parent;
- parent = parent->parentFrameView())
- parent->m_needsUpdateViewportIntersectionInSubtree = true;
-}
-
void FrameView::updateViewportIntersectionsForSubtree(
DocumentLifecycle::LifecycleState targetState) {
// TODO(dcheng): Since widget tree updates are deferred, FrameViews might
@@ -4574,10 +4565,6 @@ void FrameView::updateViewportIntersectionsForSubtree(
->intersectionObserverController()
->computeTrackedIntersectionObservations();
- if (!m_needsUpdateViewportIntersectionInSubtree)
- return;
- m_needsUpdateViewportIntersectionInSubtree = false;
-
for (Frame* child = m_frame->tree().firstChild(); child;
child = child->tree().nextSibling()) {
if (!child->isLocalFrame())
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698