Convert utility process WiFi Credentials IPC to mojo

chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc

Index: chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc b/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ff473f68b812c1b9328aa60040708f7f331240dc
--- /dev/null
+++ b/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc
@@ -0,0 +1,76 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/macros.h"
+#include "base/run_loop.h"
+#include "chrome/browser/extensions/api/networking_private/networking_private_credentials_getter.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "content/public/browser/browser_thread.h"
+
+class NetworkingPrivateCredentialsGetterTest : public InProcessBrowserTest {
+ public:
+  NetworkingPrivateCredentialsGetterTest() = default;
+
+  void RunTest(bool use_test_network_guid) {
+    base::RunLoop run_loop;
+    quit_closure_ = run_loop.QuitClosure();
+
+    getter_ = extensions::NetworkingPrivateCredentialsGetter::Create();
+    network_guid_.clear();

[Sam McNally, 2017/01/16 04:16:20]

Why?

[Noel Gordon, 2017/01/16 11:09:58]

I was thinking ... nevermind, removed.

+    if (use_test_network_guid)
+      network_guid_ = "chrome://test-wifi-get-key-from-system";

[Sam McNally, 2017/01/16 04:16:20]

This should be a shared constant somewhere.

Also, there should be one for success and one for failure.

[Noel Gordon, 2017/01/16 11:09:58]

Ack /shrug.
The empty network guid seems to handle the failure case, unless I'm missing
something.

[Noel Gordon, 2017/01/18 06:02:03]

Since the question in my mind was: well, could you define "somewhere" a little
more precisely?   We discussed various options off-line, and came up with the
idea of _somewhere_ == "in the .mojom file" [1]. 

Moral of this story: better to not guess about imprecisely stated things I feel,
since I can't read your mind - unless you've installed a WiFi network in it
recently and are cool with me calling GetWiFiCredentials() on it :D

[1] filed https://crbug.com/682102 about the mojo generated string type.

+
+    done_called_ = false;
+    content::BrowserThread::PostBlockingPoolTask(
+        FROM_HERE,
+        base::Bind(&NetworkingPrivateCredentialsGetterTest::GetCredentials,
+                   base::Unretained(this)));
+    run_loop.Run();
+
+    EXPECT_TRUE(done_called_);
+  }
+
+ private:
+  void GetCredentials() {
+    getter_->Start(

[Sam McNally, 2017/01/16 04:16:20]

Why not create the getter here? In any case, store it in a unique_ptr.

[Noel Gordon, 2017/01/16 11:09:58]

Done.

+        network_guid_, "public_key",
+        base::Bind(&NetworkingPrivateCredentialsGetterTest::CredentialsDone,
+                   base::Unretained(this)));
+    delete getter_;
+  }
+
+  void CredentialsDone(const std::string& key_data, const std::string& error) {
+    done_called_ = true;
+
+    if (!network_guid_.empty()) {
+      EXPECT_EQ(network_guid_, key_data);
+      EXPECT_EQ("", error);
+    } else {
+      EXPECT_EQ("", key_data);
+      EXPECT_FALSE(error.empty());
+    }
+
+    content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
+                                     quit_closure_);
+  }
+
+  extensions::NetworkingPrivateCredentialsGetter* getter_;
+  base::Closure quit_closure_;
+  std::string network_guid_;
+  bool done_called_;
+
+  DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateCredentialsGetterTest);
+};
+
+IN_PROC_BROWSER_TEST_F(NetworkingPrivateCredentialsGetterTest,
+                       GetCredentialsSuccess) {
+  RunTest(true);
+}
+
+IN_PROC_BROWSER_TEST_F(NetworkingPrivateCredentialsGetterTest,
+                       GetCredentialsFailure) {
+  RunTest(false);
+}