chrome/common/extensions/wifi_credentials.mojom - Issue 2610953003: Convert utility process WiFi Credentials IPC to mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/wifi_credentials.mojom

Issue 2610953003: Convert utility process WiFi Credentials IPC to mojo (Closed)

Patch Set: Delete the credentials getter_ early in the browser test. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_win.cc ('K') | « chrome/common/extensions/chrome_utility_extensions_messages.h ('k') | chrome/test/BUILD.gn » ('j') | chrome/utility/extensions/extensions_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // WiFi credentials interface provided by the utility process and exposed

	6 // by mojo policy control to the chrome browser process on OS_WIN.

	7

	8 module extensions.mojom;

	9

	10 interface WiFiCredentials {
	Sam McNally 2017/01/16 04:16:20 WifiCredentialsGetter? WifiCredentialsGetter? Noel Gordon 2017/01/16 11:09:58 Done. Show quoted text On 2017/01/16 04:16:20, Sam McNally wrote: > WifiCredentialsGetter? Done.
	11 // OS_WIN: Get plain-text WiFi credentials from the system (requires UAC

	12 // privilege elevation). Returns \|success\| false if an error occurred or

	13 // \|success\| true and the result in \|key_data\|.

	14 GetWiFiCredentials(string ssid) => (bool success, string key_data);
	tibell 2017/01/16 03:34:01 Could we instead return a `string?` (which transla Could we instead return a `string?` (which translates to std::optional<string> in the generated C++ bindings) to communicate failure? Noel Gordon 2017/01/16 09:30:05 We could I suppose, but it would diverge from the Show quoted text On 2017/01/16 03:34:01, tibell wrote: > Could we instead return a `string?` (which translates to std::optional<string> > in the generated C++ bindings) to communicate failure? We could I suppose, but it would diverge from the mac and chrome_os uses of the same API (which do not need / use the utility process). So I decided to leave it it alone.
	15 };

OLD	NEW