Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: components/gcm_driver/gcm_driver_desktop.h

Issue 2610933002: GCM: Make InstanceIDHandler implementations use protected inheritance (Closed)
Patch Set: s/implementation/overrides/ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GCM_DRIVER_GCM_DRIVER_DESKTOP_H_ 5 #ifndef COMPONENTS_GCM_DRIVER_GCM_DRIVER_DESKTOP_H_
6 #define COMPONENTS_GCM_DRIVER_GCM_DRIVER_DESKTOP_H_ 6 #define COMPONENTS_GCM_DRIVER_GCM_DRIVER_DESKTOP_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 24 matching lines...) Expand all
35 35
36 namespace gcm { 36 namespace gcm {
37 37
38 class GCMAccountMapper; 38 class GCMAccountMapper;
39 class GCMAppHandler; 39 class GCMAppHandler;
40 class GCMClientFactory; 40 class GCMClientFactory;
41 class GCMDelayedTaskController; 41 class GCMDelayedTaskController;
42 42
43 // GCMDriver implementation for desktop and Chrome OS, using GCMClient. 43 // GCMDriver implementation for desktop and Chrome OS, using GCMClient.
44 class GCMDriverDesktop : public GCMDriver, 44 class GCMDriverDesktop : public GCMDriver,
45 public InstanceIDHandler { 45 protected InstanceIDHandler {
46 public: 46 public:
47 GCMDriverDesktop( 47 GCMDriverDesktop(
48 std::unique_ptr<GCMClientFactory> gcm_client_factory, 48 std::unique_ptr<GCMClientFactory> gcm_client_factory,
49 const GCMClient::ChromeBuildInfo& chrome_build_info, 49 const GCMClient::ChromeBuildInfo& chrome_build_info,
50 const std::string& channel_status_request_url, 50 const std::string& channel_status_request_url,
51 const std::string& user_agent, 51 const std::string& user_agent,
52 PrefService* prefs, 52 PrefService* prefs,
53 const base::FilePath& store_path, 53 const base::FilePath& store_path,
54 const scoped_refptr<net::URLRequestContextGetter>& request_context, 54 const scoped_refptr<net::URLRequestContextGetter>& request_context,
55 const scoped_refptr<base::SequencedTaskRunner>& ui_thread, 55 const scoped_refptr<base::SequencedTaskRunner>& ui_thread,
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 236
237 // Used to pass a weak pointer to the IO worker. 237 // Used to pass a weak pointer to the IO worker.
238 base::WeakPtrFactory<GCMDriverDesktop> weak_ptr_factory_; 238 base::WeakPtrFactory<GCMDriverDesktop> weak_ptr_factory_;
239 239
240 DISALLOW_COPY_AND_ASSIGN(GCMDriverDesktop); 240 DISALLOW_COPY_AND_ASSIGN(GCMDriverDesktop);
241 }; 241 };
242 242
243 } // namespace gcm 243 } // namespace gcm
244 244
245 #endif // COMPONENTS_GCM_DRIVER_GCM_DRIVER_DESKTOP_H_ 245 #endif // COMPONENTS_GCM_DRIVER_GCM_DRIVER_DESKTOP_H_
OLDNEW
« no previous file with comments | « no previous file | components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698