Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm
diff --git a/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm b/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm
index 445438c6e588b55b55874d826cc6e5bca95faacd..6e05a837de24fe2fffde7b7463b5494fe2fdf2ce 100644
--- a/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm
+++ b/ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm
@@ -9,7 +9,7 @@
#include "base/logging.h"
#include "base/mac/bundle_locations.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "components/metrics/metrics_pref_names.h"
@@ -48,8 +48,6 @@ const BOOL kDefaultStatsCheckboxValue = YES;
@interface WelcomeToChromeViewController ()<WelcomeToChromeViewDelegate> {
ios::ChromeBrowserState* browserState_; // weak
TabModel* tabModel_; // weak
- base::mac::ObjCPropertyReleaser
- propertyReleaser_WelcomeToChromeViewController_;
}
// The animation which occurs at launch has run.
@@ -81,8 +79,6 @@ const BOOL kDefaultStatsCheckboxValue = YES;
if (self) {
browserState_ = browserState;
tabModel_ = tabModel;
- propertyReleaser_WelcomeToChromeViewController_.Init(
- self, [WelcomeToChromeViewController class]);
}
return self;
}
@@ -98,6 +94,11 @@ const BOOL kDefaultStatsCheckboxValue = YES;
return nil;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)loadView {
base::scoped_nsobject<WelcomeToChromeView> welcomeToChromeView(
[[WelcomeToChromeView alloc] initWithFrame:CGRectZero]);

Powered by Google App Engine
This is Rietveld 408576698