Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm b/ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm
index 35b355c09cdc516bff31b34295a66dbaf82b02b7..17b2dd9ef4af57ba1a0b1797a04d09ec9f8b629c 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_panel_view.mm
@@ -5,7 +5,7 @@
#import "ios/chrome/browser/ui/bookmarks/bookmark_panel_view.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#import "ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h"
#import "ios/chrome/browser/ui/rtl_geometry.h"
@@ -14,21 +14,16 @@
// can slide horizontally. This UIView subclass decides whether to swallow
// touches based on the transform of its subview, since its subview might lie
// outsides the bounds of itself.
-@interface MenuViewWrapper : UIView {
- base::mac::ObjCPropertyReleaser _propertyReleaser_MenuViewWrapper;
-}
+@interface MenuViewWrapper : UIView
@property(nonatomic, retain) UIView* menuView;
@end
@implementation MenuViewWrapper
@synthesize menuView = _menuView;
-- (id)initWithFrame:(CGRect)frame {
- self = [super initWithFrame:frame];
- if (self) {
- _propertyReleaser_MenuViewWrapper.Init(self, [MenuViewWrapper class]);
- }
- return self;
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
}
- (BOOL)pointInside:(CGPoint)point withEvent:(UIEvent*)event {
@@ -37,9 +32,7 @@
@end
-@interface BookmarkPanelView ()<UIGestureRecognizerDelegate> {
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkPanelView;
-}
+@interface BookmarkPanelView ()<UIGestureRecognizerDelegate>
// The content view always has the same size as this view.
// Redefined to be read-write.
@property(nonatomic, retain) UIView* contentView;
@@ -123,8 +116,6 @@
- (id)initWithFrame:(CGRect)frame menuViewWidth:(CGFloat)width {
self = [super initWithFrame:frame];
if (self) {
- _propertyReleaser_BookmarkPanelView.Init(self, [BookmarkPanelView class]);
-
DCHECK(width);
_menuWidth = width;
@@ -168,6 +159,11 @@
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
#pragma mark Gesture recognizer
- (void)panRecognized:(id)target {

Powered by Google App Engine
This is Rietveld 408576698