ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm - Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)

Patch Set: weak -> assign Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm ('k') | ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm » ('j') | ios/chrome/browser/ui/history/history_entry_item.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm

diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm b/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm

index 6f6de34a3300c6db95cfe840e7e2d698805452df..a78bf65f3707f49a9c16c8eed49ae57ea3063c2d 100644

--- a/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm

+++ b/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm

@@ -11,7 +11,7 @@

#import "base/ios/weak_nsobject.h"

#include "base/logging.h"

#include "base/mac/foundation_util.h"

-#include "base/mac/objc_property_releaser.h"

+#include "base/mac/objc_release_properties.h"

#include "base/mac/scoped_nsobject.h"

#include "base/strings/sys_string_conversions.h"

#include "components/bookmarks/browser/bookmark_model.h"

@@ -55,8 +55,6 @@ typedef NS_ENUM(NSInteger, ItemType) {

BookmarkModelBridgeObserver,

BookmarkTextFieldItemDelegate> {

std::unique_ptr<bookmarks::BookmarkModelBridge> _modelBridge;

- base::mac::ObjCPropertyReleaser

- _propertyReleaser_BookmarkFolderEditorViewController;

// Flag to ignore bookmark model Move notifications when the move is performed

// by this class.

BOOL _ignoresOwnMove;

@@ -144,8 +142,6 @@ folderEditorWithBookmarkModel:(bookmarks::BookmarkModel*)bookmarkModel

DCHECK(bookmarkModel->loaded());

self = [super initWithStyle:CollectionViewControllerStyleAppBar];

if (self) {

- _propertyReleaser_BookmarkFolderEditorViewController.Init(

- self, [BookmarkFolderEditorViewController class]);

_bookmarkModel = bookmarkModel;

// Set up the bookmark model oberver.

@@ -163,6 +159,7 @@ folderEditorWithBookmarkModel:(bookmarks::BookmarkModel*)bookmarkModel

- (void)dealloc {

_titleItem.delegate = nil;

_folderViewController.delegate = nil;

+ base::mac::ReleaseProperties(self);

[super dealloc];

}