Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.mm b/ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.mm
index b1aacd6ae4b6e08a97a44fc1fc3b283d3104f4fb..04e40846572e619f9e0e085ff266391c070065b2 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.mm
@@ -5,7 +5,7 @@
#import "ios/chrome/browser/ui/bookmarks/bookmark_all_collection_view.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "components/bookmarks/browser/bookmark_model.h"
@@ -41,7 +41,6 @@ typedef enum { kNoUpdate = 0, kOneUpdateDone, kUpdateScheduled } UpdateState;
ScopedVector<NodesSection> _nodesSectionVector;
// To avoid refreshing the internal model too often.
UpdateState _updateScheduled;
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkAllCollectionView;
}
// Keep a reference to the promo cell to deregister as delegate.
@@ -62,8 +61,6 @@ typedef enum { kNoUpdate = 0, kOneUpdateDone, kUpdateScheduled } UpdateState;
frame:(CGRect)frame {
self = [super initWithBrowserState:browserState frame:frame];
if (self) {
- _propertyReleaser_BookmarkAllCollectionView.Init(
- self, [BookmarkAllCollectionView class]);
self.accessibilityIdentifier = @"bookmark_all_collection_view";
[self updateCollectionView];
}
@@ -72,6 +69,7 @@ typedef enum { kNoUpdate = 0, kOneUpdateDone, kUpdateScheduled } UpdateState;
- (void)dealloc {
_promoCell.delegate = nil;
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698