Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm b/ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm
index 3173eddf11988fa0de2f3f5e3cc23d0e51972acc..f6c0f0dfa983f795bb0f4a1a04304b00d548bd0f 100644
--- a/ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm
+++ b/ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.mm
@@ -5,7 +5,7 @@
#import "ios/chrome/browser/ui/bookmarks/bars/bookmark_editing_bar.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#import "ios/chrome/browser/ui/bookmarks/bookmark_extended_button.h"
@@ -20,9 +20,7 @@ namespace {
CGFloat kInterButtonMargin = 24;
} // namespace
-@interface BookmarkEditingBar () {
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkEditingBar;
-}
+@interface BookmarkEditingBar ()
@property(nonatomic, retain) BookmarkExtendedButton* cancelButton;
// This label is slightly left off center, and reflects the number of bookmarks
// selected for editing.
@@ -44,7 +42,6 @@ CGFloat kInterButtonMargin = 24;
- (id)initWithFrame:(CGRect)outerFrame {
self = [super initWithFrame:outerFrame];
if (self) {
- _propertyReleaser_BookmarkEditingBar.Init(self, [BookmarkEditingBar class]);
self.backgroundColor = bookmark_utils_ios::blueColor();
CGRect bounds = self.contentView.bounds;
@@ -178,6 +175,11 @@ CGFloat kInterButtonMargin = 24;
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)setCancelTarget:(id)target action:(SEL)action {
[self.cancelButton addTarget:target
action:action

Powered by Google App Engine
This is Rietveld 408576698