Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index dac801e1c4f1db0c0e1a3326758002f4ff205054..f80ee6f33e729f852d52193d28573fe375c4aef7 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -17,7 +17,7 @@
#include "base/logging.h"
#include "base/mac/bind_objc_block.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/metrics/histogram.h"
#include "base/metrics/user_metrics.h"
@@ -233,8 +233,6 @@ enum class RendererTerminationTabState {
// YES if the Tab needs to be reloaded after the app becomes active.
BOOL requireReloadAfterBecomingActive_;
- base::mac::ObjCPropertyReleaser propertyReleaser_Tab_;
-
id<TabDelegate> delegate_; // weak
base::WeakNSProtocol<id<TabDialogDelegate>> dialogDelegate_;
base::WeakNSProtocol<id<SnapshotOverlayProvider>> snapshotOverlayProvider_;
@@ -551,7 +549,6 @@ void AddNetworkClientFactoryOnIOThread(
DCHECK(webState);
self = [super init];
if (self) {
- propertyReleaser_Tab_.Init(self, [Tab class]);
tabHistoryContext_.reset(new TabHistoryContext());
parentTabModel_ = parentModel;
browserState_ =
@@ -732,6 +729,7 @@ void AddNetworkClientFactoryOnIOThread(
// Note that -[CRWWebController close] has already been called, so nothing
// significant should be done with it in this method.
DCHECK_NE(self.webController.delegate, self);
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698