Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: ios/chrome/browser/payments/payment_request_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/payments/payment_request_view_controller.mm
diff --git a/ios/chrome/browser/payments/payment_request_view_controller.mm b/ios/chrome/browser/payments/payment_request_view_controller.mm
index 55775161c5ca586413c3f3238f104dea3106ad46..524ee142c60d61ee8acb832717b8b636cf4370f5 100644
--- a/ios/chrome/browser/payments/payment_request_view_controller.mm
+++ b/ios/chrome/browser/payments/payment_request_view_controller.mm
@@ -6,7 +6,7 @@
#import "base/ios/weak_nsobject.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "components/autofill/core/browser/autofill_data_util.h"
@@ -66,9 +66,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
base::scoped_nsobject<MDCFlatButton> _payButton;
ShippingAddressItem* _selectedShippingAddressItem;
-
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_PaymentRequestViewController;
}
// Called when the user presses the cancel button.
@@ -90,9 +87,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
- (instancetype)init {
if ((self = [super initWithStyle:CollectionViewControllerStyleAppBar])) {
- _propertyReleaser_PaymentRequestViewController.Init(
- self, [PaymentRequestViewController class]);
-
[self setTitle:l10n_util::GetNSString(IDS_IOS_PAYMENT_REQUEST_TITLE)];
// Set up left (cancel) button.
@@ -150,6 +144,11 @@ typedef NS_ENUM(NSInteger, ItemType) {
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (id<PaymentRequestViewControllerDelegate>)delegate {
return _delegate.get();
}

Powered by Google App Engine
This is Rietveld 408576698