Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Yank unrelated changes. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
index e6157e493bbd1ddc227f61e6b8c924c80f2fa7a0..4bca8b8db59ad888e363d6e913a65b0a22c4e124 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
@@ -9,7 +9,7 @@
#include "base/ios/ios_util.h"
#import "base/ios/weak_nsobject.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/metrics/field_trial.h"
#include "components/reading_list/core/reading_list_switches.h"
@@ -253,7 +253,6 @@ NS_INLINE void AnimateInViews(NSArray* views,
@interface ToolsMenuViewController ()<UICollectionViewDelegateFlowLayout,
UICollectionViewDataSource,
ReadingListMenuNotificationDelegate> {
- base::mac::ObjCPropertyReleaser _propertyReleaser_ToolsMenuViewController;
BOOL _waitForInk;
// Weak pointer to ReadingListMenuNotifier, used to set the starting values
// for the reading list badge.
@@ -474,11 +473,14 @@ NS_INLINE void AnimateInViews(NSArray* views,
}
- (void)commonInitialization {
- _propertyReleaser_ToolsMenuViewController.Init(
- self, [ToolsMenuViewController class]);
_readingListMenuNotifier.reset();
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)loadView {
[super loadView];

Powered by Google App Engine
This is Rietveld 408576698