Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: ios/chrome/browser/ui/downloads/download_manager_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Yank unrelated changes. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/downloads/download_manager_controller.mm
diff --git a/ios/chrome/browser/ui/downloads/download_manager_controller.mm b/ios/chrome/browser/ui/downloads/download_manager_controller.mm
index 96cede0dab8d410634bf982f714d2a1f83f8c9a5..96d402fd5c35830ce94ef56d26b76c1cef5ca205 100644
--- a/ios/chrome/browser/ui/downloads/download_manager_controller.mm
+++ b/ios/chrome/browser/ui/downloads/download_manager_controller.mm
@@ -12,11 +12,10 @@
#include "base/ios/weak_nsobject.h"
#include "base/location.h"
#include "base/mac/bind_objc_block.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/memory/ref_counted.h"
#include "base/metrics/histogram_macros.h"
-#include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
#include "base/strings/sys_string_conversions.h"
@@ -388,7 +387,6 @@ class DownloadContentDelegate : public URLFetcherDelegate {
// Set to YES when a file is downloaded and is used to determine if the
// DownloadedFileAction histogram needs to be recorded on -dealloc.
BOOL _recordFileActionHistogram;
- base::mac::ObjCPropertyReleaser _propertyReleaser_DownloadManagerController;
}
// The container that holds the |documentIcon|, the |progressBar|, the
@@ -525,9 +523,6 @@ class DownloadContentDelegate : public URLFetcherDelegate {
self = [super initWithNibName:@"DownloadManagerController" url:url];
if (self) {
_downloadManagerId = g_download_manager_id++;
- _propertyReleaser_DownloadManagerController.Init(
- self, [DownloadManagerController class]);
-
_requestContextGetter = requestContextGetter;
_headFetcherDelegate.reset(new DownloadHeadDelegate(self));
_contentFetcherDelegate.reset(new DownloadContentDelegate(self));
@@ -629,6 +624,7 @@ class DownloadContentDelegate : public URLFetcherDelegate {
UMA_HISTOGRAM_ENUMERATION(kUMADownloadedFileAction, NO_ACTION,
DOWNLOADED_FILE_ACTION_COUNT);
}
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698