Implement async/await/yield and async for-in

Implement async, await, yield and async for-in.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/b7c40cc2e03e201e569af1b30e538b53e3ba1478

[Emily Fortuna, 2017-01-14 01:19:05]

Patchset #2 (id:20001) has been deleted

[Emily Fortuna, 2017-01-14 01:19:10]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-01-14 01:20:04]

Description was changed from

==========
Implement async/await and ensure we're looking at the correct resolved AST when
initializing fields in constructors.

BUG=https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Implement async, await, yield and async for-in.

BUG=https://github.com/dart-lang/sdk/issues/27394
==========

[Emily Fortuna, 2017-01-14 01:20:05]

efortuna@google.com changed reviewers:
+ sra@google.com

[Emily Fortuna, 2017-01-14 01:20:42]

This causes a few more tests to pass, but mostly now the async tests fail
because of constructor body issues.

[Emily Fortuna, 2017-01-14 01:59:13]

On 2017/01/14 01:20:42, Emily Fortuna wrote:
> This causes a few more tests to pass, but mostly now the async tests fail
> because of constructor body issues.

This in combination with my previous switch CL puts us at 82.7%

[sra1, 2017-01-14 02:56:23]

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:856: pop();
push/pop = add

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:862: new ir.TryFinally(null, new
_FakeStatement(finalizerFunction)))
I'd rather buildFinallyBlock took a function (finalizerFunction).

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2406:
..buildFinallyBlock(tryFinally)
..buildFinallyBlock(() { tryFinally.finalizer.accept(this); })

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2503: void
buildFinallyBlock(ir.TryFinally tryFinally) {
buildFinallyBlock(void buildFinalizer()) {

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2507:
tryFinally.finalizer.accept(kernelBuilder);
buildFinalizer();

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2637: class _FakeStatement extends
ir.Statement {
I'm not keen on this. See other comments

[Emily Fortuna, 2017-01-17 20:58:21]

yes, that's better. PTAL

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:856: pop();
On 2017/01/14 02:56:23, sra1 wrote:
> push/pop = add

Done.

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:862: new ir.TryFinally(null, new
_FakeStatement(finalizerFunction)))
On 2017/01/14 02:56:23, sra1 wrote:
> I'd rather buildFinallyBlock took a function (finalizerFunction).

Done.

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2406:
..buildFinallyBlock(tryFinally)
On 2017/01/14 02:56:23, sra1 wrote:
> ..buildFinallyBlock(() { tryFinally.finalizer.accept(this); })

Done.

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2503: void
buildFinallyBlock(ir.TryFinally tryFinally) {
On 2017/01/14 02:56:23, sra1 wrote:
> buildFinallyBlock(void buildFinalizer()) {

Done.

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2507:
tryFinally.finalizer.accept(kernelBuilder);
On 2017/01/14 02:56:23, sra1 wrote:
> buildFinalizer();

Done.

https://codereview.chromium.org/2610903004/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2637: class _FakeStatement extends
ir.Statement {
On 2017/01/14 02:56:23, sra1 wrote:
> I'm not keen on this. See other comments

Done.

[sra1, 2017-01-18 23:14:34]

lgtm

[Emily Fortuna, 2017-01-18 23:15:39]

Description was changed from

==========
Implement async, await, yield and async for-in.

BUG=https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Implement async, await, yield and async for-in.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b7c40cc2e03e201e569af1b30e538b53e3ba1478
==========

[Emily Fortuna, 2017-01-18 23:15:40]

Committed patchset #3 (id:80001) manually as
b7c40cc2e03e201e569af1b30e538b53e3ba1478 (presubmit successful).