Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: net/cert/cert_verify_proc.cc

Issue 2610903003: [refactor] Extract the CertVerifyResult assignment of has_md2, has_md4, (Closed)
Patch Set: address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/cert_verify_proc.h ('k') | net/cert/cert_verify_proc_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc.cc
diff --git a/net/cert/cert_verify_proc.cc b/net/cert/cert_verify_proc.cc
index 91c8e95445291780d154d3d4804a46dab69580b9..f047a7e2e45b7703718460709f8a0c7a341f22ea 100644
--- a/net/cert/cert_verify_proc.cc
+++ b/net/cert/cert_verify_proc.cc
@@ -774,4 +774,32 @@ bool CertVerifyProc::HasTooLongValidity(const X509Certificate& cert) {
const base::Feature CertVerifyProc::kSHA1LegacyMode{
"SHA1LegacyMode", base::FEATURE_DISABLED_BY_DEFAULT};
+X509Certificate::SignatureHashAlgorithm FillCertVerifyResultWeakSignature(
+ X509Certificate::OSCertHandle cert,
+ bool is_leaf,
+ CertVerifyResult* verify_result) {
+ X509Certificate::SignatureHashAlgorithm hash =
+ X509Certificate::GetSignatureHashAlgorithm(cert);
+ switch (hash) {
+ case X509Certificate::kSignatureHashAlgorithmMd2:
+ verify_result->has_md2 = true;
+ break;
+ case X509Certificate::kSignatureHashAlgorithmMd4:
+ verify_result->has_md4 = true;
+ break;
+ case X509Certificate::kSignatureHashAlgorithmMd5:
+ verify_result->has_md5 = true;
+ break;
+ case X509Certificate::kSignatureHashAlgorithmSha1:
+ verify_result->has_sha1 = true;
+ if (is_leaf)
+ verify_result->has_sha1_leaf = true;
+ break;
+ case X509Certificate::kSignatureHashAlgorithmOther:
+ break;
+ }
+
+ return hash;
+}
+
} // namespace net
« no previous file with comments | « net/cert/cert_verify_proc.h ('k') | net/cert/cert_verify_proc_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698