Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2610893003: Implements CSSPropertyAPI for the stroke-dasharray property. (Closed)
Patch Set: dependencies Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index c1f9099aa4cf6269c3de013198897f7ace6e5d74..9de54a59868433d3e02ba9cbb3f2877909a6044f 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -1997,22 +1997,6 @@ static CSSValue* consumeFlexBasis(CSSParserTokenRange& range,
return consumeLengthOrPercent(range, cssParserMode, ValueRangeNonNegative);
}
-static CSSValue* consumeStrokeDasharray(CSSParserTokenRange& range) {
- CSSValueID id = range.peek().id();
- if (id == CSSValueNone)
- return consumeIdent(range);
-
- CSSValueList* dashes = CSSValueList::createCommaSeparated();
- do {
- CSSPrimitiveValue* dash =
- consumeLengthOrPercent(range, SVGAttributeMode, ValueRangeNonNegative);
- if (!dash || (consumeCommaIncludingWhitespace(range) && range.atEnd()))
- return nullptr;
- dashes->append(*dash);
- } while (!range.atEnd());
- return dashes;
-}
-
static CSSValue* consumeBaselineShift(CSSParserTokenRange& range) {
CSSValueID id = range.peek().id();
if (id == CSSValueBaseline || id == CSSValueSub || id == CSSValueSuper)
@@ -3676,8 +3660,6 @@ const CSSValue* CSSPropertyParser::parseSingleValue(
case CSSPropertyFlexGrow:
case CSSPropertyFlexShrink:
return consumeNumber(m_range, ValueRangeNonNegative);
- case CSSPropertyStrokeDasharray:
- return consumeStrokeDasharray(m_range);
case CSSPropertyColumnRuleWidth:
return consumeColumnRuleWidth(m_range, m_context.mode());
case CSSPropertyStrokeOpacity:

Powered by Google App Engine
This is Rietveld 408576698