Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3028)

Unified Diff: chrome/app/chrome_crash_reporter_client_mac.mm

Issue 2610883006: Enable UMA reporting for crashpad_handler on macOS (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_crash_reporter_client.h ('k') | chrome/app/chrome_crash_reporter_client_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_mac.mm
diff --git a/chrome/app/chrome_crash_reporter_client_mac.mm b/chrome/app/chrome_crash_reporter_client_mac.mm
index 03cf48b6bb40fc3112104f4433ba1972a211890b..40656a0ad704519d13e9d7ace4d13cb458a0c778 100644
--- a/chrome/app/chrome_crash_reporter_client_mac.mm
+++ b/chrome/app/chrome_crash_reporter_client_mac.mm
@@ -7,7 +7,9 @@
#include <CoreFoundation/CoreFoundation.h>
#include "base/mac/scoped_cftyperef.h"
+#include "base/path_service.h"
#include "base/strings/sys_string_conversions.h"
+#include "chrome/common/chrome_paths.h"
#include "components/policy/policy_constants.h"
#if !defined(DISABLE_NACL)
@@ -17,6 +19,15 @@
#include "native_client/src/trusted/service_runtime/osx/crash_filter.h"
#endif
+bool ChromeCrashReporterClient::GetCrashMetricsLocation(
+ base::FilePath* metrics_dir) {
+#if defined(GOOGLE_CHROME_BUILD)
scottmg 2017/01/05 22:41:40 The #if feels like unnecessary clutter here.
+ return PathService::Get(chrome::DIR_USER_DATA, metrics_dir);
+#else
+ return false;
+#endif
+}
+
bool ChromeCrashReporterClient::ReportingIsEnforcedByPolicy(
bool* breakpad_enabled) {
base::ScopedCFTypeRef<CFStringRef> key(
« no previous file with comments | « chrome/app/chrome_crash_reporter_client.h ('k') | chrome/app/chrome_crash_reporter_client_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698