Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2610823004: Replace using MockSdk with FolderBasedDartSdk + summaries in AbstractContextTest(s). (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace using MockSdk with FolderBasedDartSdk + summaries in AbstractContextTest(s). It has some performance penalty (about 2-3 seconds in 35 seconds total). R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1e43b4f270ec67d2b8281419324d1edbf749572c

Patch Set 1 #

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-04 22:18:41 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-04 22:23:31 UTC) #2
scheglov
3 years, 11 months ago (2017-01-04 22:39:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e43b4f270ec67d2b8281419324d1edbf749572c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698