Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2610813006: Add UseCounters for alert(), confirm() and prompt() usage against site engagement. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index 072efbeee2d8de568d9b1df76cce41f89f5de464..a02b9a719497add21bb39e288c461aadd3ae46be 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -745,6 +745,27 @@ void LocalDOMWindow::alert(ScriptState* scriptState, const String& message) {
return;
}
+ switch (document()->getEngagementLevel()) {
+ case mojom::blink::EngagementLevel::NONE:
+ UseCounter::count(document(), UseCounter::AlertEngagementNone);
+ break;
+ case mojom::blink::EngagementLevel::MINIMAL:
+ UseCounter::count(document(), UseCounter::AlertEngagementMinimal);
+ break;
+ case mojom::blink::EngagementLevel::LOW:
+ UseCounter::count(document(), UseCounter::AlertEngagementLow);
+ break;
+ case mojom::blink::EngagementLevel::MEDIUM:
+ UseCounter::count(document(), UseCounter::AlertEngagementMedium);
+ break;
+ case mojom::blink::EngagementLevel::HIGH:
+ UseCounter::count(document(), UseCounter::AlertEngagementHigh);
+ break;
+ case mojom::blink::EngagementLevel::MAX:
+ UseCounter::count(document(), UseCounter::AlertEngagementMax);
+ break;
+ }
+
if (v8::MicrotasksScope::IsRunningMicrotasks(scriptState->isolate())) {
UseCounter::count(document(), UseCounter::During_Microtask_Alert);
}
@@ -774,6 +795,27 @@ bool LocalDOMWindow::confirm(ScriptState* scriptState, const String& message) {
return false;
}
+ switch (document()->getEngagementLevel()) {
+ case mojom::blink::EngagementLevel::NONE:
+ UseCounter::count(document(), UseCounter::ConfirmEngagementNone);
+ break;
+ case mojom::blink::EngagementLevel::MINIMAL:
+ UseCounter::count(document(), UseCounter::ConfirmEngagementMinimal);
+ break;
+ case mojom::blink::EngagementLevel::LOW:
+ UseCounter::count(document(), UseCounter::ConfirmEngagementLow);
+ break;
+ case mojom::blink::EngagementLevel::MEDIUM:
+ UseCounter::count(document(), UseCounter::ConfirmEngagementMedium);
+ break;
+ case mojom::blink::EngagementLevel::HIGH:
+ UseCounter::count(document(), UseCounter::ConfirmEngagementHigh);
+ break;
+ case mojom::blink::EngagementLevel::MAX:
+ UseCounter::count(document(), UseCounter::ConfirmEngagementMax);
+ break;
+ }
+
if (v8::MicrotasksScope::IsRunningMicrotasks(scriptState->isolate())) {
UseCounter::count(document(), UseCounter::During_Microtask_Confirm);
}
@@ -805,6 +847,27 @@ String LocalDOMWindow::prompt(ScriptState* scriptState,
return String();
}
+ switch (document()->getEngagementLevel()) {
+ case mojom::blink::EngagementLevel::NONE:
+ UseCounter::count(document(), UseCounter::PromptEngagementNone);
+ break;
+ case mojom::blink::EngagementLevel::MINIMAL:
+ UseCounter::count(document(), UseCounter::PromptEngagementMinimal);
+ break;
+ case mojom::blink::EngagementLevel::LOW:
+ UseCounter::count(document(), UseCounter::PromptEngagementLow);
+ break;
+ case mojom::blink::EngagementLevel::MEDIUM:
+ UseCounter::count(document(), UseCounter::PromptEngagementMedium);
+ break;
+ case mojom::blink::EngagementLevel::HIGH:
+ UseCounter::count(document(), UseCounter::PromptEngagementHigh);
+ break;
+ case mojom::blink::EngagementLevel::MAX:
+ UseCounter::count(document(), UseCounter::PromptEngagementMax);
+ break;
+ }
+
if (v8::MicrotasksScope::IsRunningMicrotasks(scriptState->isolate())) {
UseCounter::count(document(), UseCounter::During_Microtask_Prompt);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698