Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2610813003: Fix DDC cross-window JS interop on FireFox. (Closed)

Created:
3 years, 11 months ago by Jacob
Modified:
3 years, 11 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 years, 11 months ago (2017-01-04 21:33:50 UTC) #2
vsm
lgtm
3 years, 11 months ago (2017-01-04 22:13:53 UTC) #3
Jacob
3 years, 11 months ago (2017-01-04 22:15:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93fb5d81199a46d1d07929fc045ba5926c05eaa0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698