Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3692)

Unified Diff: chrome/test/BUILD.gn

Issue 2610793002: Add a browser test for the views external protocol dialog. (Closed)
Patch Set: CreateDialog is a macro on Windows -_- Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index c0451695e6743062c8349665b47db9b7178f4b87..07147a7c2fe23445e24b9734e56533084248551e 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -2120,7 +2120,10 @@ test("browser_tests") {
]
deps += [ "//ui/views" ]
if (!is_chromeos && (!is_mac || mac_views_browser)) {
- sources += [ "../browser/ui/views/profiles/profile_chooser_view_browsertest.cc" ]
+ sources += [
+ "../browser/ui/views/external_protocol_dialog_browsertest.cc",
+ "../browser/ui/views/profiles/profile_chooser_view_browsertest.cc",
+ ]
}
if (!is_mac || mac_views_browser) {
sources += [
@@ -3125,7 +3128,6 @@ test("unit_tests") {
"../browser/engagement/site_engagement_helper_unittest.cc",
"../browser/engagement/site_engagement_score_unittest.cc",
"../browser/engagement/site_engagement_service_unittest.cc",
- "../browser/external_protocol/external_protocol_handler_unittest.cc",
tapted 2017/01/04 23:32:49 why remove this?
dominickn 2017/01/04 23:51:36 Oops! My new test was originally a unit test, so I
"../browser/favicon/chrome_fallback_icon_client_unittest.cc",
"../browser/file_select_helper_unittest.cc",
"../browser/geolocation/geolocation_permission_context_unittest.cc",

Powered by Google App Engine
This is Rietveld 408576698