Issue 2610753002: Fix front end perf after addition of Source to kernel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2610753002: Fix front end perf after addition of Source to kernel. (Closed)

Created:
3 years, 11 months ago by Paul Berry

Modified:
3 years, 11 months ago

Reviewers:
jensj, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix front end perf after addition of Source to kernel. Commit aecb572d769726cbc0413c2ac15f8bdaf73c4445 introduced errors into the front end perf script by making it ambiguous whether "Source" refers to the kernel's "Source" or the front end's. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/62edaa7a63dcd964b0de9bea4d6f0bce8c5fc5ce

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/front_end/tool/perf.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 11 months ago (2017-01-03 21:26:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
62edaa7a63dcd964b0de9bea4d6f0bce8c5fc5ce (presubmit successful).