Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: extensions/renderer/api_binding_unittest.cc

Issue 2610743002: [Extensions Bindings] Make function definitions optional for an API. (Closed)
Patch Set: api_binding_unittest Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_binding_unittest.cc
diff --git a/extensions/renderer/api_binding_unittest.cc b/extensions/renderer/api_binding_unittest.cc
index 114915c6b91620193f65293d266d0f6fc3fd778d..1d1182c24525531503d46772d7b729bd1c33348b 100644
--- a/extensions/renderer/api_binding_unittest.cc
+++ b/extensions/renderer/api_binding_unittest.cc
@@ -194,7 +194,7 @@ TEST_F(APIBindingUnittest, Test) {
ASSERT_TRUE(functions);
ArgumentSpec::RefMap refs;
APIBinding binding(
- "test", *functions, nullptr, nullptr,
+ "test", functions.get(), nullptr, nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
EXPECT_TRUE(refs.empty());
@@ -295,7 +295,7 @@ TEST_F(APIBindingUnittest, TypeRefsTest) {
ASSERT_TRUE(types);
ArgumentSpec::RefMap refs;
APIBinding binding(
- "test", *functions, types.get(), nullptr,
+ "test", functions.get(), types.get(), nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
EXPECT_EQ(2u, refs.size());
@@ -341,7 +341,7 @@ TEST_F(APIBindingUnittest, RestrictedAPIs) {
ASSERT_TRUE(functions);
ArgumentSpec::RefMap refs;
APIBinding binding(
- "test", *functions, nullptr, nullptr,
+ "test", functions.get(), nullptr, nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
@@ -384,7 +384,7 @@ TEST_F(APIBindingUnittest, TestEventCreation) {
ASSERT_TRUE(functions);
ArgumentSpec::RefMap refs;
APIBinding binding(
- "test", *functions, nullptr, events.get(),
+ "test", functions.get(), nullptr, events.get(),
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
@@ -420,7 +420,7 @@ TEST_F(APIBindingUnittest, TestDisposedContext) {
ASSERT_TRUE(functions);
ArgumentSpec::RefMap refs;
APIBinding binding(
- "test", *functions, nullptr, nullptr,
+ "test", functions.get(), nullptr, nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
base::MakeUnique<APIBindingHooks>(binding::RunJSFunction()), &refs);
EXPECT_TRUE(refs.empty());
@@ -466,7 +466,7 @@ TEST_F(APIBindingUnittest, TestCustomHooks) {
hooks->RegisterHandleRequest("test.oneString", base::Bind(hook, &did_call));
APIBinding binding(
- "test", *functions, nullptr, nullptr,
+ "test", functions.get(), nullptr, nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
std::move(hooks), &refs);
EXPECT_TRUE(refs.empty());
@@ -517,7 +517,7 @@ TEST_F(APIBindingUnittest, TestJSCustomHook) {
ArgumentSpec::RefMap refs;
APIBinding binding(
- "test", *functions, nullptr, nullptr,
+ "test", functions.get(), nullptr, nullptr,
base::Bind(&APIBindingUnittest::OnFunctionCall, base::Unretained(this)),
std::move(hooks), &refs);
EXPECT_TRUE(refs.empty());

Powered by Google App Engine
This is Rietveld 408576698