Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3874)

Unified Diff: extensions/renderer/api_binding.h

Issue 2610743002: [Extensions Bindings] Make function definitions optional for an API. (Closed)
Patch Set: api_binding_unittest Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/api_binding.cc » ('j') | extensions/renderer/api_binding_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding.h
diff --git a/extensions/renderer/api_binding.h b/extensions/renderer/api_binding.h
index b4353a95276c3cc5c643365a3b09326dc8838ff4..8ba87d0daeaa5c462ffa25eaeeafd5c191511790 100644
--- a/extensions/renderer/api_binding.h
+++ b/extensions/renderer/api_binding.h
@@ -57,10 +57,10 @@ class APIBinding {
using HandlerCallback = base::Callback<void(gin::Arguments*)>;
// The ArgumentSpec::RefMap is required to outlive this object.
- // |type_definitions| and |event_definitions| may be null if the API does not
- // specify any types or events.
+ // |function_definitions|, |type_definitions| and |event_definitions|
+ // may be null if the API does not specify any types or events.
Devlin 2017/01/04 15:49:14 s/types or events/of the given category or somethi
jbroman 2017/01/04 19:55:43 Done.
APIBinding(const std::string& name,
- const base::ListValue& function_definitions,
+ const base::ListValue* function_definitions,
const base::ListValue* type_definitions,
const base::ListValue* event_definitions,
const APIMethodCallback& callback,
« no previous file with comments | « no previous file | extensions/renderer/api_binding.cc » ('j') | extensions/renderer/api_binding_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698