components/ntp_snippets/category_rankers/constant_category_ranker.h - Issue 2610553002: [NTP::SectionOrder] Make ClickBasedRanker move dismissed sections down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/category_rankers/constant_category_ranker.h

Issue 2610553002: [NTP::SectionOrder] Make ClickBasedRanker move dismissed sections down. (Closed)

Patch Set: jkrcal@ comment. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/category_rankers/click_based_category_ranker_unittest.cc ('k') | components/ntp_snippets/category_rankers/constant_category_ranker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/category_rankers/constant_category_ranker.h

diff --git a/components/ntp_snippets/category_rankers/constant_category_ranker.h b/components/ntp_snippets/category_rankers/constant_category_ranker.h

index 6d2a14329bcf113732c4e4f2a59012b8b541dede..67786b208b3fe8825322d020d9e8be7fa886704b 100644

--- a/components/ntp_snippets/category_rankers/constant_category_ranker.h

+++ b/components/ntp_snippets/category_rankers/constant_category_ranker.h

@@ -28,6 +28,7 @@ class ConstantCategoryRanker : public CategoryRanker {

void ClearHistory(base::Time begin, base::Time end) override;

void AppendCategoryIfNecessary(Category category) override;

void OnSuggestionOpened(Category category) override;

+ void OnCategoryDismissed(Category category) override;

static std::vector<KnownCategories> GetKnownCategoriesDefaultOrder();