Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: components/ntp_snippets/category_rankers/click_based_category_ranker.h

Issue 2610553002: [NTP::SectionOrder] Make ClickBasedRanker move dismissed sections down. (Closed)
Patch Set: jkrcal@ comment. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/category_rankers/click_based_category_ranker.h
diff --git a/components/ntp_snippets/category_rankers/click_based_category_ranker.h b/components/ntp_snippets/category_rankers/click_based_category_ranker.h
index 4b3a8a20f5fea117da0d0b8fe158c74f5f4df477..698940d737ea91ced36525e07ad1a8d927c07619 100644
--- a/components/ntp_snippets/category_rankers/click_based_category_ranker.h
+++ b/components/ntp_snippets/category_rankers/click_based_category_ranker.h
@@ -33,6 +33,7 @@ class ClickBasedCategoryRanker : public CategoryRanker {
void ClearHistory(base::Time begin, base::Time end) override;
void AppendCategoryIfNecessary(Category category) override;
void OnSuggestionOpened(Category category) override;
+ void OnCategoryDismissed(Category category) override;
static void RegisterProfilePrefs(PrefRegistrySimple* registry);
@@ -44,6 +45,10 @@ class ClickBasedCategoryRanker : public CategoryRanker {
// passing margin). For testing only.
static int GetNumTopCategoriesWithExtraMargin();
+ // Returns number of positions by which a dismissed category is downgraded.
+ // For testing only.
+ static int GetDismissedCategoryPenalty();
+
private:
struct RankedCategory {
Category category;

Powered by Google App Engine
This is Rietveld 408576698