Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 261053004: Simplify RenderLayer::setParent (Closed)

Created:
6 years, 7 months ago by abarth-chromium
Modified:
6 years, 7 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, zoltan1, dsinclair, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink, chrishtr, Ian Vollick
Visibility:
Public.

Description

Simplify RenderLayer::setParent There's no need call these functions on RenderLayerCompositor. RenderLayer::addChild and RenderLayer::removeChild already call them. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173140

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove function #

Total comments: 1

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M LayoutTests/compositing/squashing/tricky-element-removal-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
abarth-chromium
6 years, 7 months ago (2014-05-01 21:49:17 UTC) #1
esprehn
lgtm https://codereview.chromium.org/261053004/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/261053004/diff/1/Source/core/rendering/RenderLayer.cpp#newcode3617 Source/core/rendering/RenderLayer.cpp:3617: m_parent = parent; This should be inline now. ...
6 years, 7 months ago (2014-05-01 21:50:41 UTC) #2
abarth-chromium
6 years, 7 months ago (2014-05-01 21:57:32 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 7 months ago (2014-05-01 21:57:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/261053004/20001
6 years, 7 months ago (2014-05-01 21:58:18 UTC) #5
esprehn
The CQ bit was unchecked by esprehn@chromium.org
6 years, 7 months ago (2014-05-01 22:00:38 UTC) #6
esprehn
https://codereview.chromium.org/261053004/diff/20001/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/261053004/diff/20001/Source/core/rendering/RenderLayer.cpp#newcode1407 Source/core/rendering/RenderLayer.cpp:1407: m_parent = this; This isn't right, you meant child->m_parent ...
6 years, 7 months ago (2014-05-01 22:00:43 UTC) #7
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 7 months ago (2014-05-01 22:42:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/261053004/40001
6 years, 7 months ago (2014-05-01 22:42:22 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 00:14:26 UTC) #10
Message was sent while issue was closed. 
Change committed as 173140

Powered by Google App Engine
This is Rietveld 408576698