Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2610513005: Use Entity instead of Element in ConstantValue (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 9 chunks +14 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/constructors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/visitor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-03 12:34:05 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-03 17:48:57 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-04 09:23:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a510d4fd3e267de91733c3ab75f20a57ebbcd1d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698